[BugFix] Fix list partition pruning of multi-value partitions containing NULL (backport #78946) - #78962
Open
mergify[bot] wants to merge 1 commit into
Open
[BugFix] Fix list partition pruning of multi-value partitions containing NULL (backport #78946)#78962mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
ListPartitionPrunerprunes!=,NOT INandIS NOT NULLbyallPartitions - nullPartitions, butnullPartitionsholds every partition whose value list contains NULL. A multi-value partition likeVALUES IN ("beijing", NULL)is dropped as a whole and its non-null rows are lost. An equi join derivescol IS NOT NULLon the join key, soJOIN ... ON f.city = d.cityhits it too.What I'm doing:
Only drop NULL-only partitions for null-rejecting predicates: a partition is removed only if it is in nullPartitions and holds a single value (isSingleValuePartition), the same guard the literal removal already uses. External tables (no ListPartitionInfo) are unchanged since each partition holds one value. IS NULL and <=> NULL keep using the "contains NULL" set.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #78946 done by [Mergify](https://mergify.com).