[Enhancement] Skip predicate column vacuuming when TTL is negative or usage is empty#71290
Open
seokyun-ha-toss wants to merge 2 commits intoStarRocks:mainfrom
Open
[Enhancement] Skip predicate column vacuuming when TTL is negative or usage is empty#71290seokyun-ha-toss wants to merge 2 commits intoStarRocks:mainfrom
seokyun-ha-toss wants to merge 2 commits intoStarRocks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
I'm using StarRocks with
enable_predicate_columns_collection=falseand have truncated the_statistics_.predicate_columnstable. However, the vacuum process with TTL is still running and generating useless audit logs. I want to suppress predicate column vacuuming by disabling predicate column TTL.What I'm doing:
When
statistic_predicate_columns_ttl_hoursis set to a negative value (e.g.-1), skip vacuuming entirely.Additionally, skip vacuuming
id2columnUsagewhen it is already empty before removal:Already, reflect the changes on documents also.
Fixes #71291
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: