Skip to content

Fix filter log mapping for empty filters #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trader-payne merged 1 commit into from
Jun 4, 2025
Merged

Fix filter log mapping for empty filters #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dtop/views/log_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def prev_search_match(search_matches, current_match, line_positions, wrap_log_li
def filter_logs(logs, filter_string, case_sensitive=False):
"""Filter logs with advanced expression support"""
if not filter_string:
return logs, [] # Return original logs if no filter
return logs, list(range(len(logs))) # Return original logs with mapping if no filter

# Parse the filter expression
tokens = parse_filter_expression(filter_string)
Expand Down