chore(deps): update dependencies and tidy up typescript typing#365
Merged
giamir merged 16 commits intoStackExchange:mainfrom Jan 15, 2025
Merged
chore(deps): update dependencies and tidy up typescript typing#365giamir merged 16 commits intoStackExchange:mainfrom
giamir merged 16 commits intoStackExchange:mainfrom
Conversation
Bumps [prosemirror-markdown](https://github.com/prosemirror/prosemirror-markdown) from 1.12.0 to 1.13.1. - [Changelog](https://github.com/ProseMirror/prosemirror-markdown/blob/master/CHANGELOG.md) - [Commits](ProseMirror/prosemirror-markdown@1.12.0...1.13.1) --- updated-dependencies: - dependency-name: prosemirror-markdown dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [prosemirror-model](https://github.com/prosemirror/prosemirror-model) from 1.19.4 to 1.24.1. - [Changelog](https://github.com/ProseMirror/prosemirror-model/blob/master/CHANGELOG.md) - [Commits](ProseMirror/prosemirror-model@1.19.4...1.24.1) --- updated-dependencies: - dependency-name: prosemirror-model dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [prosemirror-view](https://github.com/prosemirror/prosemirror-view) from 1.33.3 to 1.37.1. - [Changelog](https://github.com/ProseMirror/prosemirror-view/blob/master/CHANGELOG.md) - [Commits](ProseMirror/prosemirror-view@1.33.3...1.37.1) --- updated-dependencies: - dependency-name: prosemirror-view dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…ror-markdown-1.13.1' into jsmb/update-deps
…ror-model-1.24.1' into jsmb/update-deps
…ror-view-1.37.1' into jsmb/update-deps
giamir
changed the title
giamir
requested changes
Jan 14, 2025
Contributor
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
Thanks for the PR. ❤️
Changes look reasonable to me so far, but there are some unit and e2e tests failing we should look into before merging. It might also be the upgraded version of the libraries break our test expectations. Hopefully that's not the case because it could make the upgrade not as straightforward.
Once tests are passing I will take another look.
Thank you
giamir
approved these changes
Jan 14, 2025
Contributor
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
Looks good to me. I will let @dancormier also take a look. If he cannot find anything as well we are good to merge. Thanks a lot for helping us upgrade few dependencies. ❤️
dancormier
approved these changes
Jan 14, 2025
Contributor
dancormier
left a comment
dancormier
left a comment
There was a problem hiding this comment.
Ran the tests, spun up the editor locally, and checked out the code. Everything ran/looked good to me, so this gets my stamp of approval. Thanks for this @threefjefff!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping version of prosemirror and markdown-it to latest.
This necessitated a cleanup of how we call markdown-it's types and utility functions; rather than reaching into the internals, this now references the public interface.