Conversation
philon-msft
approved these changes
Jul 16, 2025
Collaborator
|
Maybe this wasn't flagged before because we execute CLEINT ID as fire-and-forget during handshake? Absence of ConnectionId should definitely cause tests to fail, but I don't see any library code that has a hard dependency on it. Are we TOO tolerant of protocol failures? |
Collaborator
Author
We're not even slightly tolerant of them. In my local testing, it was burning the connection constantly. Protocol failures are deemed fatal. |
mgravell
added a commit
that referenced
this pull request
Jul 18, 2025
* Fix CLIENT ID error during handshake * update release notes * tilde
mgravell
added a commit
that referenced
this pull request
Jul 18, 2025
* Fix CLIENT ID error during handshake * update release notes * tilde
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is odd; no idea how this hasn't already flagged, but: the
CLIENT IDissued in handshake breaks connections - the auto-config handler didn't report success correctly, leading it to manifest as a protocol failure.This is probably urgent. I also wonder whether this relates to any of our test breaks. Potentially impacts any servers with version >= 5, which... huh, also includes our entire test suite. Very confused.