Skip to content

Add retry mechanism for cURL requests #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vitexus merged 1 commit into from
Sep 24, 2025
Merged

Add retry mechanism for cURL requests #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/Discomp/ApiClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ class ApiClient extends \Ease\Molecule
*/
private string $apiPassword;

/**
* Discomp API Retry count on curl error.
*/
private int $retryCount = 10;

/**
* May be huge response.
*
Expand All @@ -91,6 +96,7 @@ public function __construct($username = '', $password = '')
$this->apiUsername = \strlen($username) ? $username : \Ease\Shared::cfg('DISCOMP_USERNAME');
$this->apiPassword = \strlen($password) ? $password : \Ease\Shared::cfg('DISCOMP_PASSWORD');
$this->debug = strtolower((string) \Ease\Shared::cfg('DISCOMP_API_DEBUG', false)) === 'True';
$this->retryCount = (int) \Ease\Shared::cfg('DISCOMP_RETRY', 10);
$this->curlInit();
$this->setObjectName();
}
Expand Down Expand Up @@ -160,19 +166,27 @@ public function curlInit()
public function doCurlRequest($url, $method = 'GET', $postParams = [])
{
curl_setopt($this->curl, \CURLOPT_URL, $url);

curl_setopt($this->curl, \CURLOPT_CUSTOMREQUEST, strtoupper($method));

$this->lastCurlResponse = curl_exec($this->curl);
$this->curlInfo = curl_getinfo($this->curl);
$this->curlInfo['when'] = microtime();
$this->lastResponseCode = $this->curlInfo['http_code'];
$this->lastCurlError = curl_error($this->curl);
for ($try = 1; $try <= $this->retryCount; $try++) {
$this->lastCurlResponse = curl_exec($this->curl);
$this->curlInfo = curl_getinfo($this->curl);
$this->curlInfo['when'] = microtime();
$this->lastResponseCode = $this->curlInfo['http_code'];
$this->lastCurlError = curl_error($this->curl);

if (\strlen($this->lastCurlError)) {
$msg = sprintf('Curl Error (HTTP %d): %s', $this->lastResponseCode, $this->lastCurlError);
$this->addStatusMessage(sprintf(_('Try %d/%d: %s'), $try, $this->retryCount, $msg), 'warning');
sleep(60);
} else {
break; // No error, exit the loop
}
}

if (\strlen($this->lastCurlError)) {
$msg = sprintf('Curl Error (HTTP %d): %s', $this->lastResponseCode, $this->lastCurlError);
$this->addStatusMessage($msg, 'error');

if ($this->throwException) {
throw new \Ease\Exception($msg, $this->lastResponseCode);
}
Expand Down