implementing bio-metric pull#59
Conversation
Rollback alpha
Feature/biometric
|
Hey @maifeeulasad I have reviewed your PR it looks good. But the main purpose of this Bio-Metric authentication is to provide But in above picture we clearly see able to see the dashboard values. Also I noticed application crashes whenever I tap apart from the the authenticate area. Can you please fix above two issues if possible. Once it's done I will be happy to merge your PR. Thanks for your PR. Have a great day buddy! |
…l + refactored PrefsDataStore, as it is being used in multiple class across multiple files now without proper authentication app can't be used, as well as even the values from different views can't be seen
|
@Spikeysanju can you check out once more, I've update the PR. currently it starts in a different fragment, an authentication fragment. then if it is properly authenticated, it goes to doing whatever it was doing previously. You can check directly here : ca9ad27 And let me know if it needs something more. |
…ashboardFragment it would appear
|
@maifeeulasad Buddy thanks for the new PR. I will review this PR by EOD. Have a great day 🙌 |
|
Hello, @Spikeysanju hope you are doing well. Have you checked out this PR. Can I get any update on this? If this PR lacks anything, please let me know. |
2 participants
Issue : #52
Discussion : #58