Standalone: Add and use GLFWException for standalone use#124
Merged
RedEpicness merged 1 commit intomasterfrom Feb 26, 2026
Merged
Standalone: Add and use GLFWException for standalone use#124RedEpicness merged 1 commit intomasterfrom
RedEpicness merged 1 commit intomasterfrom
Conversation
Traben-0
approved these changes
Feb 21, 2026
|
|
||
| package gg.essential.universal.standalone.glfw | ||
|
|
||
| @Suppress("MemberVisibilityCanBePrivate", "CanBeParameter") |
Contributor
There was a problem hiding this comment.
Question: I assume the intention here is to read these vals elsewhere? e.g. the installer
Contributor
Author
There was a problem hiding this comment.
Correct, the plan is for the installer to read these and act upon, more specifically the specific code received and also log the GLFW message.
RedEpicness
deleted the
feature/improve-standalone-glfw-error-handling
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone version of UC simply throws a RuntimeException when failing to create a window. This PR exposes the underlying GLFW error in a more structured way, as opposed to only including it in the exception message. This is desired for better exception handling in the Essential installer.