fix: resolve dead code, type inconsistency, PEP 8, and logging format…#1518
Open
overhyped-pratham wants to merge 1 commit into
Open
fix: resolve dead code, type inconsistency, PEP 8, and logging format…#1518overhyped-pratham wants to merge 1 commit into
overhyped-pratham wants to merge 1 commit into
Conversation
… issues - in_memory_cache.py: Fix delete() return type annotation (was None, returns bool) - in_memory_cache.py: Remove unreachable eturn False in clear() method - base_registry.py: Fix mixed int/str type for time_since_last_seen in remove() - observability.py: Add missing PEP 8 blank lines between class definitions - message_utils.py: Use lazy %s logging format instead of eager f-strings - artifact_utils.py: Use lazy %s logging format instead of eager f-strings Signed-off-by: overhyped-pratham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… issues
in_memory_cache.py: Fix delete() return type annotation (was None, returns bool)
in_memory_cache.py: Remove unreachable
eturn False in clear() method
base_registry.py: Fix mixed int/str type for time_since_last_seen in remove()
observability.py: Add missing PEP 8 blank lines between class definitions
message_utils.py: Use lazy %s logging format instead of eager f-strings
artifact_utils.py: Use lazy %s logging format instead of eager f-strings
What is the purpose of this change?
How was this change implemented?
Key Design Decisions (optional - delete if not applicable)
How was this change tested?
Is there anything the reviewers should focus on/be aware of?