fix: Faulty GUI size rendering when browser is set to non-standard font size#1688
Open
hummelstrand wants to merge 1 commit intomainfrom
Open
fix: Faulty GUI size rendering when browser is set to non-standard font size#1688hummelstrand wants to merge 1 commit intomainfrom
hummelstrand wants to merge 1 commit intomainfrom
Conversation
…ndard scaling chore: Added a Bootstrap CSS customization to get around the faulty size rendering of the entire GUI only when the URL parameter 'zoom' is set to '100' or no localStorage variable 'uiZoomLevel' exists, that occurs when the user has a local, non-default font size rendering.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
WalkthroughA single CSS custom property for default body font size (16px) was added to the root selector in the bootstrap customization stylesheet, establishing a baseline font size variable. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Added a Bootstrap CSS customization to get around the faulty size rendering of the entire GUI only when the URL parameter 'zoom' is set to '100' or no localStorage variable 'uiZoomLevel' exists, that occurs when the user has a local, non-default font size rendering.
About the Contributor
Posted on behalf of SuperFly.tv
Type of Contribution
This is a:
Bug fix
Current Behavior
When the user's local browser has its "Appearance" – "Font Size" set to a non-standard value, in combination with the Sofie URL parameter 'zoom' being passed in as '100' and/or the localStorage variable 'uiZoomLevel' being set to '1', the entire Sofie GUI scales incorrectly. If either 'zoom' or 'uiZoomLevel' is set to any other values than 100%, the GUI scales correctly.
This is likely a regression caused by the change to Bootstrap.
New Behavior
The fix causes the GUI to display correctly at 100% even though the user has a non-standard 'font scaling' parameter set in their browser.
Testing
Affected areas
Time Frame
Other Information
Status