Add WeakWindow for preventing VRAM leaks from stale handles #1929
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wayland protocol objects (e.g. ZcosmicToplevelHandleV1) can outlive the surfaces they reference. When ToplevelHandleState holds a strong Window reference, the entire chain (WindowInner → WlSurface → SurfaceData → data_map → GPU textures) stays alive, leaking VRAM. Add Window::downgrade() → WeakWindow so consumers can store weak references that do not prevent resource cleanup. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
WeakWindowandWindow::downgradeto help compositors fix and prevent issues like Closing windows causes VRAM memory leak (#1562)More details in issue linked above and in pop-os/cosmic-comp#2084
tl;dr:
WeakWindowholds a weak reference to the underlying window resources, avoiding the strongArcreference that keeps GPU buffers alive after a window is closed. Callupgrade()to get back anOption<Window>.