Skip to content

fix Bug #4304 #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eygwi wants to merge 2 commits into
base: experimental
Choose a base branch
from
+9 −5
Open

fix Bug #4304 #4343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e02ed48
fix Bug #4304
eygwi Dec 16, 2025
212bf81
Fix Pickaxe of Vein Mining destroying Slimefun blocks
eygwi Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions ...va/io/github/thebusybiscuit/slimefun4/implementation/items/tools/PickaxeOfVeinMining.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import org.bukkit.inventory.ItemStack;

import io.github.bakedlibs.dough.blocks.Vein;
import io.github.bakedlibs.dough.items.CustomItemStack;
import io.github.bakedlibs.dough.protection.Interaction;
import io.github.thebusybiscuit.slimefun4.api.items.ItemGroup;
import io.github.thebusybiscuit.slimefun4.api.items.ItemSetting;
Expand All @@ -24,6 +23,7 @@
import io.github.thebusybiscuit.slimefun4.implementation.Slimefun;
import io.github.thebusybiscuit.slimefun4.implementation.items.SimpleSlimefunItem;
import io.github.thebusybiscuit.slimefun4.utils.tags.SlimefunTag;
import me.mrCookieSlime.Slimefun.api.BlockStorage;

/**
* The {@link PickaxeOfVeinMining} is a powerful tool which allows you to mine an entire vein of ores
Expand All @@ -48,22 +48,26 @@ public PickaxeOfVeinMining(ItemGroup itemGroup, SlimefunItemStack item, RecipeTy
return (e, tool, fortune, drops) -> {
if (SlimefunTag.PICKAXE_OF_VEIN_MINING_BLOCKS.isTagged(e.getBlock().getType())) {
List<Block> blocks = Vein.find(e.getBlock(), maxBlocks.getValue(), b -> SlimefunTag.PICKAXE_OF_VEIN_MINING_BLOCKS.isTagged(b.getType()));
breakBlocks(e.getPlayer(), blocks, fortune, tool);
breakBlocks(e.getPlayer(), blocks, tool);
}
};
}

@ParametersAreNonnullByDefault
private void breakBlocks(Player p, List<Block> blocks, int fortune, ItemStack tool) {
private void breakBlocks(Player p, List<Block> blocks, ItemStack tool) {
for (Block b : blocks) {
if (BlockStorage.check(b.getLocation()) != null) {
continue;
}

if (Slimefun.getProtectionManager().hasPermission(p, b.getLocation(), Interaction.BREAK_BLOCK)) {
b.getWorld().playEffect(b.getLocation(), Effect.STEP_SOUND, b.getType());

if (tool.containsEnchantment(Enchantment.SILK_TOUCH)) {
b.getWorld().dropItemNaturally(b.getLocation(), new ItemStack(b.getType()));
} else {
for (ItemStack drop : b.getDrops(tool)) {
b.getWorld().dropItemNaturally(b.getLocation(), drop.getType().isBlock() ? drop : CustomItemStack.create(drop, fortune));
b.getWorld().dropItemNaturally(b.getLocation(), drop);
}
}

Expand All @@ -72,4 +76,4 @@ private void breakBlocks(Player p, List<Block> blocks, int fortune, ItemStack to
}
}

}
}