fix: remove bartering drop order bias by shuffling candidates (#4326)#4336
Closed
1vers1on wants to merge 1 commit intoSlimefun:experimentalfrom
Closed
fix: remove bartering drop order bias by shuffling candidates (#4326)#43361vers1on wants to merge 1 commit intoSlimefun:experimentalfrom
1vers1on wants to merge 1 commit intoSlimefun:experimentalfrom
Conversation
Contributor
|
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
Contributor
Author
|
i broke the commit name |
Contributor
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4336/ad1d8a32
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the piglin barter drop uses a
HashSetfor iteration, which results in a deterministic order after the set is finalized.Proposed changes
SlimefunRegistrycalledgetRandomizedBarteringDrops(), which copies thebarterDropsinto aListand shuffles it withThreadLocalRandom.HashSet.Related Issues (if applicable)
Resolves #4326
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values