Initial support for ITG and Pump Couples - #709
Merged
Merged
Conversation
CrashCringle12
force-pushed
the
routine
branch
2 times, most recently
from
March 9, 2026 06:28
6faec65 to
d397fe2
Compare
aryla
reviewed
Mar 14, 2026
aryla
reviewed
Mar 14, 2026
CrashCringle12
force-pushed
the
routine
branch
3 times, most recently
from
March 19, 2026 16:16
3842f0a to
9fed795
Compare
teejusb
force-pushed
the
itgmania-beta
branch
2 times, most recently
from
March 19, 2026 22:03
c5bebe8 to
927d133
Compare
Noteskin defaults for couples
…r routine's ScreenGameplayShared add some edge casing to ensure settings are the same for each player
include switch profile under "Profile" sorts as people frequently expect it to also be listed there given the name alone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial support and handling for Routine mode in both dance and pump modes. It also includes several fixes for AutoSetStyle and pump that are related. These changes only affect when you're in couples mode or if you have AutoSetStyle enabled.
Evaluation
ScreenEvaluation will now show the "Team" score and the per player score when you're playing a couples chart. You get the full breakdown for each player. The Arrows Pane will show your stats per player across the whole pad.
Judging
Each player will receive judgements color coded (P1 is Blue, and P2 is Red). This also applies to their combos.
Enabling AutoSetStyle (or setting your PreferredStyle to auto) would break the difficulty selector if you had a chart with > 5 total charts from multiple playable modes. For example a chart with 5 singles charts and 5 doubles charts would not visibly scroll reliably and would jump through.
^ This is a major issue for pump as many pump charts come with a ton of difficulties making it extremely difficult to scroll through. (Viewable by just trying out any of the pump official charts) Playing with AutoSetStyle is "standard" behavior in pump environments, especially given the existence of couples. I included the tabbed layout when this is enabled specifically so that these are visible as it was not a nice user experience when you're playing charts that have > 5 charts across all styles. Most of these AutoSetStyle changes including the tabbed layout come from quietly. Noting the PRs since they have relevant details in them:
CrashCringle12#13
CrashCringle12#11
CrashCringle12#10
CrashCringle12#12
CrashCringle12#15
When AutoSetStyle is enabled there was no way of knowing what style a chart was as it only displayed the number. This was a notable issue in PlayerOptions so there's helper text to display what the style is both in the wheel and in player options.
Adjusted PlayerOptions so that most options that aren't in the below highlighted box are OneChoiceForAllPlayers:
Enabling
Uncommenting these lines will make couples and such visible. Currently is not selectable: CrashCringle12@da26977, There's improvements to be made, but this makes the mode usable and fixes existing issues w/ autosetstyle.
Requires:
itgmania/itgmania#1216