test(alerts): add e2e for alerts - #12349
Open
H4ad wants to merge 19 commits into
Open
Conversation
H4ad
marked this pull request as ready for review
August 2, 2026 22:54
H4ad
requested review from
a team,
AshwinBhatkal and
therealpandey
as code owners
August 2, 2026 22:54
therealpandey
requested changes
Aug 3, 2026
| RUN --mount=type=cache,target=/go/pkg/mod \ | ||
| --mount=type=cache,target=/root/.cache/go-build \ | ||
| GOARCH=${TARGETARCH} GOOS=${OS} go build -C ./cmd/enterprise -race -tags timetzdata -o /root/signoz \ | ||
| GOARCH=${TARGETARCH} GOOS=${OS} go build -C ./cmd/enterprise -tags timetzdata -o /root/signoz \ |
Member
There was a problem hiding this comment.
If we remove the race flag @H4ad, the build cache will become useless and thrash with the integration build cache effectively meaning no cache.
| "main": "index.js", | ||
| "scripts": { | ||
| "preinstall": "npx only-allow pnpm", | ||
| "env:start": "cd .. && uv run pytest --basetemp=./tmp/ -vv --reuse --with-web e2e/bootstrap/setup.py::test_setup", |
Member
There was a problem hiding this comment.
This has changed now to make use of the build cache. Please see the updated command in contributing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📄 Summary
This adds a bunch of E2E tests for alerts, to test v1/v2 create and edit, and also tests for alert history.
This started as tests only for history but decided to just add tests for everything, while creating them, I found two bugs inside alerts, so they already helping us before even landing :)
The changes in the UI are only to add testIds, no change in logic (and no fix for the incidents)
main)Alerts page shell (7)
page.spec.tspage.spec.tspage.spec.tspage.spec.tspage.spec.tspage.spec.tspage.spec.tsAlert rules list (19)
list/columns.spec.tslist/columns.spec.tslist/columns.spec.tslist/navigation.spec.tslist/navigation.spec.tslist/navigation.spec.tslist/navigation.spec.tslist/navigation.spec.tslist/pagination-sort.spec.tslist/pagination-sort.spec.tslist/pagination-sort.spec.tslist/row-actions.spec.tslist/row-actions.spec.tslist/row-actions.spec.tslist/search.spec.tslist/search.spec.tslist/search.spec.tslist/search.spec.tslist/search.spec.tsCreate alert (52)
create/edge.spec.tscreate/edge.spec.tscreate/edge.spec.tscreate/prefill.spec.tscreate/prefill.spec.tscreate/prefill.spec.tscreate/prefill.spec.tscreate/prefill.spec.tscreate/prefill.spec.tscreate/shell.spec.tscreate/shell.spec.tscreate/shell.spec.tscreate/shell.spec.tscreate/shell.spec.tscreate/shell.spec.tscreate/shell.spec.tscreate/shell.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v1.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tscreate/v2.spec.tsEdit alert (22)
edit/edge.spec.tsedit/edge.spec.tsedit/v1.spec.tsedit/v1.spec.tsedit/v1.spec.tsedit/v1.spec.tsedit/v1.spec.tsedit/v1.spec.tsedit/v1.spec.tsedit/v1.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsedit/v2.spec.tsAlert details (15)
details/actions.spec.tsdetails/actions.spec.tsdetails/actions.spec.tsdetails/chrome.spec.tsdetails/chrome.spec.tsdetails/chrome.spec.tsdetails/header.spec.tsdetails/header.spec.tsdetails/not-found.spec.tsdetails/not-found.spec.tsdetails/rename.spec.tsdetails/rename.spec.tsdetails/tabs.spec.tsdetails/tabs.spec.tsdetails/threshold-persistence.spec.tsAlert history (75)
history/cross-cutting.spec.tshistory/cross-cutting.spec.tshistory/cross-cutting.spec.tshistory/cross-cutting.spec.tshistory/cross-cutting.spec.tshistory/cross-cutting.spec.tshistory/cross-cutting.spec.tshistory/cross-cutting.spec.tshistory/empty-and-errors.spec.tshistory/empty-and-errors.spec.tshistory/empty-and-errors.spec.tshistory/empty-and-errors.spec.tshistory/empty-and-errors.spec.tshistory/empty-and-errors.spec.tshistory/empty-and-errors.spec.tshistory/empty-and-errors.spec.tshistory/empty-and-errors.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/expression-filter.spec.tshistory/state-filter.spec.tshistory/state-filter.spec.tshistory/state-filter.spec.tshistory/state-filter.spec.tshistory/state-filter.spec.tshistory/state-filter.spec.tshistory/statistics.spec.tshistory/statistics.spec.tshistory/statistics.spec.tshistory/statistics.spec.tshistory/statistics.spec.tshistory/statistics.spec.tshistory/statistics.spec.tshistory/statistics.spec.tshistory/timeline-graph.spec.tshistory/timeline-graph.spec.tshistory/timeline-graph.spec.tshistory/timeline-pagination.spec.tshistory/timeline-pagination.spec.tshistory/timeline-pagination.spec.tshistory/timeline-pagination.spec.tshistory/timeline-pagination.spec.tshistory/timeline-pagination.spec.tshistory/timeline-pagination.spec.tshistory/timeline-pagination.spec.tshistory/timeline-pagination.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/timeline-table.spec.tshistory/top-contributors.spec.tshistory/top-contributors.spec.tshistory/top-contributors.spec.tshistory/top-contributors.spec.tshistory/top-contributors.spec.tshistory/top-contributors.spec.tshistory/top-contributors.spec.tsNotification channels (1)
channels/edit.spec.tsSkipped tests
create/edge.spec.tstest.skip(create/v1.spec.tstest.skip(history/statistics.spec.tstest.skip(true)history/timeline-table.spec.tstest.skip(true)pendingandrecoveringare transient states, and no fixture can reliably catch a rule mid-transition.history/timeline-table.spec.tstest.skip(true)disabledhistory row is policy-driven, and disabling a rule appends no row (verified).history/timeline-table.spec.tstest.skip(true)startand one atstart-1msmeans controlling row timestamps, but evaluation times are whatever the ruler chose.list/columns.spec.tstest.skip(true)list/navigation.spec.tstest.skip(true)GET /api/v1/rulesfail on demand, and the suite does not stub the network. Left explicitly untested rather than mocked.create/shell.spec.tsANOMALY_DETECTIONfeature flag is active; it is off on this stack.details/chrome.spec.tsclipboard-readnowhere else.Issues closed by this PR
Closes https://github.com/SigNoz/engineering-pod/issues/4917
✅ Change Type
Select all that apply
📝 Changelog
📋 Checklist