using a single thread for all PID controller statuses #973
+3,300
−3,288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagayan
reviewed
Jan 12, 2026
adriangudas
force-pushed
the
adriangudas/adaptive-cb-single-thread
branch
from
bf18038 to
fdb1a6b
Compare
stop thread if the last remaining circuit breaker is destroyed use a sliding interval of 1 (run through the loop every second)
adriangudas
force-pushed
the
adriangudas/adaptive-cb-single-thread
branch
from
404d2da to
af67ec2
Compare
adriangudas
commented
Jan 23, 2026
lib/semian/pid_controller_thread.rb
Outdated
| end | ||
| end | ||
|
|
||
| # @update_thread = if Fiber.scheduler |
Author
There was a problem hiding this comment.
this was accidentally commented out by mistake
anagayan
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create one monitoring thread that's shared amongst all Adaptive Circuit Breaker objects. Uses Fibers instead of threads if a fiber scheduler is available (as in SFR).