bug fix: for loop with async

[zhu-xiaoming]

can not delete the video in windows

[Soljia]

Might be best to track the PIDs of the ffmpeg processes that are spawned, and kill by PID. That way we aren't killing random ffmpeg instances that may be there.

[Soljia]

Please fix all whitespaces issues. Specifically cameras.js which looks to have nothing changes but whitespace.

Edit: Ignore this

[Soljia]

As in the conversation section, it might be best to keep track of PIDs spawned and kill based on that instead of name. This way we avoid killing random ffmpeg instances.

[moeiscool]

i'm seriously impressed by the changes you made. Currently I am in the middle of 3 projects and it has been eating up a lot of my time lately (which I sort of asked for) and along the way with all that i found a lot of bugs and many bugs were reported which, simply put, I haven't had a chance to push to the public repo.

The reason i tell you this is because of your changes im not sure how well those fixes will merge back to your branch.. because really i want these changes 😃

I'll try to push a few tonight before i go to bed so we can see how well they are going to merge with your branch.

and thank you for doing this! Maybe you can shoot me a direct message and we can talk about sharing developer support efforts. 😄

[moeiscool]

@Soljia what whitespace issues? can you link to the line number plz?

[Soljia]

You know what, never mind. I think he's fixing the comment denotations '//' to be next to the line in question, and not at the beginning of the line. My bad. 👍

[Soljia]

Ratio suggestion

[Soljia]

Can we maybe do some maths? Or is that over thinking it? Just thinking of other ratios like 16:10, or whatever may come of the future.

var gcd = function(a, b) {
    if ( ! b) {
        return a;
    }

    return gcd(b, a % b);
};

var ratio = function(height, width){
	var divisor = gcd(height, width);
  return height/divisor + ':' + width/divisor;
}