Add Async Support for PySNC #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'm pretty happy with this, will approve when marked ready. The only other consideration i had would be making this an optional feature so we don't pollute the basic dependencies for people who don't need async? Though I haven't ever tried this and not sure what the cost:benefit ratio is here |
vetsin
approved these changes
Sep 8, 2025
Collaborator
vetsin
left a comment
vetsin
left a comment
There was a problem hiding this comment.
awesome! thank you for doing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a set of new classes to enable async use of PySNC.
TODO: