test: Add support for the -s option#26566
Open
LucasChollet wants to merge 1 commit intoSerenityOS:masterfrom
Open
test: Add support for the -s option#26566LucasChollet wants to merge 1 commit intoSerenityOS:masterfrom
LucasChollet wants to merge 1 commit intoSerenityOS:masterfrom
Conversation
github-actions
bot
added
the
👀 pr-needs-review
nico
reviewed
Jan 22, 2026
| if (!FileSystem::exists(m_path)) | ||
| return false; | ||
|
|
||
| auto maybe_size = FileSystem::size_from_stat(m_path); |
Contributor
There was a problem hiding this comment.
Doing two syscalls (one for "exists" and one to get the size) seems unnecessary. stat() tells you if it exists as well.
Maybe call Core::System::stat and then do the "or existing directory" as well?
nico
added
⏳ pr-waiting-for-author
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.