Skip to content

Fix JSConversionTest >> #testDateAndTime in GemStone 3.7.5.#1514

Merged
jbrichau merged 1 commit intoSeasideSt:masterfrom
kurtkilpela:DateAndTime-javascriptOn
Jan 25, 2026
Merged

Fix JSConversionTest >> #testDateAndTime in GemStone 3.7.5.#1514
jbrichau merged 1 commit intoSeasideSt:masterfrom
kurtkilpela:DateAndTime-javascriptOn

Conversation

@kurtkilpela
Copy link
Contributor

Ensure seconds is rendered as an integer.

DateAndTime instances in GemStone/S 3.7.5 will include fractional results for #second. Pharo and prior versions of GemStone/S return integer values.

This change fixes JSConversionTest >> #testDateAndTime in GemStone 3.7.5.

DateAndTime instances in GemStone/S 3.7.5 will include fractional results for #second. Pharo and prior versions of GemStone/S return integer values.

This change fixes `JSConversionTest >> #testDateAndTime` in GemStone 3.7.5.
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.91%. Comparing base (1e1775c) to head (f8adb52).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
+ Coverage   52.28%   52.91%   +0.62%     
==========================================
  Files        9350     9202     -148     
  Lines       77740    76778     -962     
==========================================
- Hits        40649    40626      -23     
+ Misses      37091    36152     -939     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jbrichau jbrichau merged commit 4ba6efc into SeasideSt:master Jan 25, 2026
17 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants