@to_kw macro for easy boundary conditions#215
Open
anandijain wants to merge 3 commits intoSciML:masterfrom
Open
@to_kw macro for easy boundary conditions#215anandijain wants to merge 3 commits intoSciML:masterfrom
@to_kw macro for easy boundary conditions#215anandijain wants to merge 3 commits intoSciML:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
+ Coverage 74.93% 76.79% +1.85%
==========================================
Files 37 37
Lines 1851 1870 +19
==========================================
+ Hits 1387 1436 +49
+ Misses 464 434 -30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Deal, try get this to pass first though :) |
Contributor
Author
|
Seems good now |
Member
|
Looks good, can you move out |
Contributor
Author
|
I allowed edits by maintainers, mind doing that so it looks right to you? |
Member
|
Sure, I'll get to this. Thanks for your contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I write the code, you write the docs :P
feel free to unexport or change stuff