Export InvPreconditioner - #1272
Merged
ChrisRackauckas merged 2 commits intoAug 30, 2026
Merged
Conversation
Expose the existing documented inverse-preconditioner wrapper as public API and cover its exported status. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.151.0 Agent-Model: gpt-5.6-sol Agent-Session: local session ID 01a04fab-48db-7e03-9f47-20c69464527f
ChrisRackauckas
marked this pull request as ready for review
August 30, 2026 00:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
InvPreconditioneralready has a docstring and rendered manual entries, but it is not exported and therefore is not public API. Export it so downstream packages can use the inverse-preconditioner wrapper without reaching into LinearSolve internals. This unblocks the requested cleanup in SciML/OrdinaryDiffEq.jl#4391 (comment).This public API addition should be included in a LinearSolve 5.15.0 or later minor release. The version is not changed here because LinearSolve performs version bumps in dedicated release PRs.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Failing before / passing after
On exact parent
50563b88, the focused public-API assertion failed:With this change, the same command exits 0. It also exits 0 on Julia 1.10.11.
The two-line committed assertion was removed by @ChrisRackauckas during review at #1272 (comment); the commands above are the retained fail-before/pass-after evidence.
Verification
Julia 1.11.9:
The isolated depot was necessary because this host's global CondaPkg Pixi cache contains zero-byte Python files left by the 2026-08-22 disk-full incident. Clean
upstream/mainand this branch both build the docs successfully with the isolated depot; this is local cache corruption, not a repository failure.Not verified
GPU-specific groups and optional solver backend groups were not run locally. No dependency is added or changed.
🤖 Generated with Codex CLI 0.151.0 (model: gpt-5.6-sol; session: local session ID 01a04fab-48db-7e03-9f47-20c69464527f)