Fix GPU expv! allocation in hermitian branch for Real t#200
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Dec 16, 2025
Merged
Conversation
Use lmul!(t, F.values) for Real t to avoid allocation in the hermitian branch. For Complex t, allocation is unavoidable since F.values is Real and multiplying by complex t requires type conversion. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes allocation in the GPU
expv!hermitian branch for Realtby usinglmul!(t, F.values)instead oft * F.values.Changes:
t: Useslmul!(t, F.values)which modifies in place - non-allocatingt: Usest * F.values- allocation is unavoidable sinceF.valuesis Real and multiplying by complextrequires type conversionThis also inlines the two GPU methods (previously shared an internal
_expv_gpu_impl!function) since they now have different implementations in the hermitian branch.Test plan
🤖 Generated with Claude Code