Fix equalizer presets output in JSON, YAML, and ENV formats#468
Merged
Conversation
Fixes #458 - SteelSeries Arctis 7+ and other devices now properly output equalizer preset names and values in all output formats. Changes: - Add EqualizerPresetData struct and equalizer_presets field to output - Implement getEqualizerPresets() for SteelSeries devices: - Arctis 7+ - Arctis Nova 3 - Arctis Nova 3P Wireless - Arctis Nova 5 - Arctis Nova 7 - Fix YAML output to include equalizer, equalizer_presets_count, equalizer_presets, and parametric_eq fields (were missing entirely) - Fix ENV output to include equalizer info and presets - Add getEqualizerPresets() to test device for testing The equalizer_presets array now shows preset names and band values in all output formats (JSON, YAML, ENV).
Changes format from:
"equalizer_presets": [{"name": "Flat", "values": [...]}]
to:
"equalizer_presets": {"flat": [...], "bass": [...]}
This maintains backward compatibility with the existing API.
Preset names are lowercased for consistency.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458 - SteelSeries Arctis 7+ and other devices now properly output equalizer preset names and values in all output formats.
Changes:
The equalizer_presets array now shows preset names and band values in all output formats (JSON, YAML, ENV).