Add Wavetable constructor that performs per-table normalization#93
Open
CrushedPixel wants to merge 1 commit intoSamiPerttu:masterfrom
Open
Add Wavetable constructor that performs per-table normalization#93CrushedPixel wants to merge 1 commit intoSamiPerttu:masterfrom
CrushedPixel wants to merge 1 commit intoSamiPerttu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
Wavetable::new_normalizedthat performs normalization for each generated table instead of applying uniform gain across all generated tables. Without this, wavetables that do not have a strong fundamental end up much quieter in high octaves compared to low octaves.This is a comparison of the two constructors, playing C0, C1, C2, C3, C4 to compare:
I am open to changing the name of this constructor function if you prefer.