Skip to content

Change capacity to be optional and fix capacity field#2113

Open
hei98 wants to merge 7 commits intomasterfrom
heiheidi/web-139-fix-capacity-to-be-not-required
Open

Change capacity to be optional and fix capacity field#2113
hei98 wants to merge 7 commits intomasterfrom
heiheidi/web-139-fix-capacity-to-be-not-required

Conversation

@hei98
Copy link
Copy Markdown
Contributor

@hei98 hei98 commented Mar 16, 2026

No description provided.

@hei98 hei98 marked this pull request as ready for review March 16, 2026 20:35
@hei98 hei98 requested review from andsamfu and robines as code owners March 16, 2026 20:35
Copy link
Copy Markdown
Contributor

@StenOskar StenOskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut:)

Copy link
Copy Markdown
Contributor

@Lidavic Lidavic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm:)

@hei98 hei98 self-assigned this Mar 19, 2026
Copy link
Copy Markdown
Contributor

@eilifhl eilifhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut!

@robines
Copy link
Copy Markdown
Member

robines commented Mar 30, 2026

Det funker kanskje, men er ikke særlig gjenbrukbart, spesielt siden NumberInput ikke tas i bruk her. Det blir nok flere steder hvor vi trenger å ha en optional number, og det blir tungvint å skulle kopiere dette hver gang. Men det er ikke heeelt straight-forward hvordan man skal løse det for NumberInput (støtter ikke undefined atm) og zod uten å brekke ting. Skal undersøke det litt nøyere når jeg har tid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants