sssd man-page: Add missing data type in man-page - #8768
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the SSSD man page documentation in src/man/sssd.conf.5.xml by adding explicit type annotations (such as string and boolean) to several PAM-related configuration options, including pam_initgroups_scheme, pam_gssapi_services, pam_gssapi_check_upn, and pam_gssapi_indicators_map. There are no review comments to address, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
justin-stephenson
left a comment
justin-stephenson
left a comment
There was a problem hiding this comment.
Thank you for the PR. Could you add the data type to other options with missing data types?
I did a quick glance at man sssd.conf and found others such as...
fd_limit
client_idle_timeout
cache_first
|
Sure, I will do that & re-submit. |
eceffc9 to
20546de
Compare
A few others I found with no data type listed are below, please add them as well. |
Sure, I will add them as well. Also, I will re-verify the man-page if there is anything left. |
20546de to
39643d2
Compare
asakure
changed the title
39643d2 to
c0d2f9b
Compare
|
@asakure Please also rebase this PR over SSSD master branch, thank you. |
c0d2f9b to
dbd3eb1
Compare
dbd3eb1 to
b2dd6f4
Compare
justin-stephenson
added
Trivial
This patch adds missing data (value) type in sssd.conf(5) man-page for following options: pam_initgroups_scheme, pam_gssapi_services, pam_gssapi_check_upn, pam_gssapi_indicators_map, fd_limit, cache_idle_timeout, cache_first, services, domains, domain_resolution_order, responder_idle_timeout, default_shell, pam_gssapi_indicators_apply, enabled. Resolves: SSSD#7323 Resolves: SSSD#7324 Resolves: SSSD#7325 Resolves: SSSD#7326 Signed-off-by: Akshay Sakure <asakure@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com>
b2dd6f4 to
cf5f89b
Compare
3 participants
This patch adds missing data (value) type in sssd.conf(5)
man-page for following options:
pam_initgroups_scheme, pam_gssapi_services,
pam_gssapi_check_upn, pam_gssapi_indicators_map,
fd_limit, cache_idle_timeout, cache_first,
services, domains, domain_resolution_order,
responder_idle_timeout, default_shell,
pam_gssapi_indicators_apply, enabled.
Resolves: #7323
Resolves: #7324
Resolves: #7325
Resolves: #7326