Skip to content

sssd man-page: Add reference to FAILOVER section - #8760

Merged
justin-stephenson merged 1 commit into
SSSD:masterfrom
asakure:man_page_failover
Jun 9, 2026
Merged

sssd man-page: Add reference to FAILOVER section#8760
justin-stephenson merged 1 commit into
SSSD:masterfrom
asakure:man_page_failover

Conversation

@asakure

@asakure asakure commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Currently, FAILOVER section is not available in sssd.conf(5) man-page. This patch improves the statement about FAILOVER section mentioning its availability in other man-pages for example sssd-ldap(5).

Resolves: #7339

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sssd.conf.5.xml man page to explicitly reference the sssd-ldap(5), sssd-krb5(5), sssd-ipa(5), and sssd-ad(5) man pages for failover information. The reviewer recommends using the proper DocBook XML markup for these man page references to ensure correct formatting and hyperlinking in the generated outputs.

Comment thread src/man/sssd.conf.5.xml Outdated
Comment thread src/man/sssd.conf.5.xml Outdated
Comment thread src/man/sssd.conf.5.xml Outdated
@asakure
asakure force-pushed the man_page_failover branch 2 times, most recently from e0af89f to cd76d3d Compare June 1, 2026 18:07

@justin-stephenson justin-stephenson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't insist but I think it would be more concise to say

Please see the section FAILOVER in any of the sssd-provider man pages for more information about the service resolution.

@asakure

asakure commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

I don't insist but I think it would be more concise to say

Please see the section FAILOVER in any of the sssd-provider man pages for more information about the service resolution.

Yes, this will help to keep it simple but it shouldn't misguide admins (if they misread).

@justin-stephenson justin-stephenson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as it does address #7339

@justin-stephenson justin-stephenson added backport-to-sssd-2-9 backport-to-sssd-2-13 Trivial A single reviewer is sufficient to review the Pull Request Accepted labels Jun 9, 2026
Currently, FAILOVER section is not available in sssd.conf(5)
man-page. This patch improves the statement about FAILOVER section
mentioning its availability in other man-pages for example sssd-ldap(5).

Resolves: SSSD#7339
Signed-off-by: Akshay Sakure <asakure@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
@sssd-bot

sssd-bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

The pull request was accepted by @justin-stephenson with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 testing-farm:fedora-43-x86_64:upstream (success)
🟢 testing-farm:fedora-44-x86_64:centos-stream-10 (success)
🟢 testing-farm:fedora-44-x86_64:upstream (success)
🔴 testing-farm:fedora-rawhide-x86_64:upstream (failure)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🔴 ci / intgcheck (centos-10) (failure)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
🔴 ci / system (centos-10) (failure)
🟢 ci / system (fedora-43) (success)
🔴 ci / system (fedora-44) (failure)
🔴 ci / system (fedora-45) (failure)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🔴 Static code analysis / python-system-tests (failure)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the man_page_failover branch from cd76d3d to 0cab9dd Compare June 9, 2026 15:13
@justin-stephenson
justin-stephenson merged commit 817b002 into SSSD:master Jun 9, 2026
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted backport-to-sssd-2-9 backport-to-sssd-2-13 Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sssd.conf(5): "Please see the section “FAILOVER” for more information about the service resolution." No such section "FAILOVER"

3 participants