#13670 - Adds missing labels for statistics - Database Export #13784
Conversation
📝 WalkthroughWalkthroughAdds 11 new DatabaseTable localization keys across many locale property files (system configuration values/categories, notifier, drug susceptibility, special case accesses, environments, adverse events, document-related entities), updates EVENT_ENVIRONMENTS caption, and adds DateFilterOption.EPI_WEEK in several locales. Changes are localized text additions and line-normalizations only. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 11
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
sormas-api/src/main/resources/enum_zh-CN.properties (1)
375-389: Untranslated entries across multiple locale files, not just Chinese.This is a systemic localization issue affecting multiple language locales. Lines 375–389 in
enum_zh-CN.propertiesintroduce 11 newDatabaseTableentries and 1DateFilterOptionentry, all in English. However, the same entries are also untranslated in other locale files likeenum_de-DE.propertiesandenum_de-CH.properties, despite these being functional translation files with proper German translations elsewhere (e.g.,ActionContext.EVENT = Ereignis).The entries requiring translation across all affected locale files are:
- SYSTEM_CONFIGURATION_VALUES
- SYSTEM_CONFIGURATION_CATEGORIES
- NOTIFIER
- DRUG_SUSCEPTIBILITY
- SPECIAL_CASE_ACCESSES
- ENVIRONMENTS
- EVENT_ENVIRONMENTS
- ADVERSE_EVENTS_FOLLOWING_IMMUNIZATIONS
- ADVERSE_EVENTS_FOLLOWING_IMMUNIZATION_INVESTIGATIONS
- ADVERSE_EVENTS
- DOCUMENT_RELATED_ENTITIES
- DateFilterOption.EPI_WEEK
This appears to stem from commit 4d59577 ("Adds missing labels for statistics - Database Export"), which added these entries across multiple locale-specific property files without providing translations. Verify that proper translations are provided across all affected locales (Chinese, German, French, and others) or apply them in a follow-up commit.
sormas-api/src/main/resources/enum_fr-FR.properties (1)
375-389: Missing French translations for newly added DatabaseTable entries; systemic localization issue affecting all language files.All 11 newly added
DatabaseTableentries (lines 375–387) are in English ("System configuration values", "Notifier", "Drug susceptibility", etc.) instead of French. This breaks the established localization pattern—otherDatabaseTableentries in this file are properly translated (e.g.,Cas,Événements,Contacts,Zone de santé).Notably,
DateFilterOption.EPI_WEEK(line 389) is correctly translated to French ("Par semaine"), indicating awareness of the localization requirement. The untranslated entries appear to be a copy-paste error from the English base properties file.This is a systemic issue: the same 11 untranslated entries appear across all non-English locale files (German, Arabic, Czech, and others), meaning French-speaking users and speakers of other non-English languages will see English UI labels in the Database Export feature section, creating a poor localization experience and failing to address the original issue (#13670) for non-English users.
sormas-api/src/main/resources/enum_tr-TR.properties (1)
290-295: Critical: enum_tr-TR.properties is out of sync with enum_en-KE.properties.Comparing the two locale files reveals that enum_tr-TR.properties is missing the following entry that exists in enum_en-KE.properties:
DashboardType.ADVERSE_EVENTS = Adverse EventsThis entry should be present at line 294 in enum_tr-TR (after
DashboardType.CAMPAIGNS = Campaigns). This preexisting synchronization issue affects the completeness of the Turkish locale resource bundle and may cause missing labels in the UI for Turkish-language users.Action required: Add the missing DashboardType.ADVERSE_EVENTS entry to enum_tr-TR.properties to restore parity with enum_en-KE.properties.
🔎 Proposed fix
Insert after line 293 in enum_tr-TR.properties:
DashboardType.CAMPAIGNS = Campaigns + DashboardType.ADVERSE_EVENTS = Adverse Events # DatabaseTablesormas-api/src/main/resources/enum_fr-CH.properties (1)
294-294: Untranslated DashboardType entry in French locale file.Line 294 contains
DashboardType.ADVERSE_EVENTS = Adverse Events, which is in English. For a French locale file (enum_fr-CH.properties), this should be translated to French (e.g., "Événements indésirables").
🧹 Nitpick comments (1)
sormas-api/src/main/resources/enum_es-BO.properties (1)
375-385: New DatabaseTable captions correctly wired; optional future localizationThe added
DatabaseTable.*entries line up with the English base file and will allow the new database-export tables to show proper labels instead of raw enum names in the Statistics → Database Export view. For this PR’s goal, this is sufficient.If/when you do a translation pass on
enum_es-BO.properties, these values are good candidates to localize from English to Spanish to be consistent with the rest of the locale.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (45)
sormas-api/src/main/resources/enum.propertiessormas-api/src/main/resources/enum_ar-SA.propertiessormas-api/src/main/resources/enum_cs-CZ.propertiessormas-api/src/main/resources/enum_de-CH.propertiessormas-api/src/main/resources/enum_de-DE.propertiessormas-api/src/main/resources/enum_en-AF.propertiessormas-api/src/main/resources/enum_en-GH.propertiessormas-api/src/main/resources/enum_en-GM.propertiessormas-api/src/main/resources/enum_en-KE.propertiessormas-api/src/main/resources/enum_en-LR.propertiessormas-api/src/main/resources/enum_en-NG.propertiessormas-api/src/main/resources/enum_es-BO.propertiessormas-api/src/main/resources/enum_es-CU.propertiessormas-api/src/main/resources/enum_es-EC.propertiessormas-api/src/main/resources/enum_es-ES.propertiessormas-api/src/main/resources/enum_fa-AF.propertiessormas-api/src/main/resources/enum_fi-FI.propertiessormas-api/src/main/resources/enum_fil-PH.propertiessormas-api/src/main/resources/enum_fj-FJ.propertiessormas-api/src/main/resources/enum_fr-CD.propertiessormas-api/src/main/resources/enum_fr-CH.propertiessormas-api/src/main/resources/enum_fr-FR.propertiessormas-api/src/main/resources/enum_fr-TN.propertiessormas-api/src/main/resources/enum_hi-IN.propertiessormas-api/src/main/resources/enum_hr-HR.propertiessormas-api/src/main/resources/enum_it-CH.propertiessormas-api/src/main/resources/enum_it-IT.propertiessormas-api/src/main/resources/enum_ja-JP.propertiessormas-api/src/main/resources/enum_lv-LV.propertiessormas-api/src/main/resources/enum_ne-NP.propertiessormas-api/src/main/resources/enum_nl-NL.propertiessormas-api/src/main/resources/enum_no-NO.propertiessormas-api/src/main/resources/enum_pl-PL.propertiessormas-api/src/main/resources/enum_ps-AF.propertiessormas-api/src/main/resources/enum_pt-BR.propertiessormas-api/src/main/resources/enum_pt-CV.propertiessormas-api/src/main/resources/enum_pt-PT.propertiessormas-api/src/main/resources/enum_ro-RO.propertiessormas-api/src/main/resources/enum_ru-RU.propertiessormas-api/src/main/resources/enum_sv-SE.propertiessormas-api/src/main/resources/enum_sw-KE.propertiessormas-api/src/main/resources/enum_tr-TR.propertiessormas-api/src/main/resources/enum_uk-UA.propertiessormas-api/src/main/resources/enum_ur-PK.propertiessormas-api/src/main/resources/enum_zh-CN.properties
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: SORMAS CI
- GitHub Check: android app test (27)
- GitHub Check: android app test (28)
- GitHub Check: android app test (26)
🔇 Additional comments (72)
sormas-api/src/main/resources/enum_sw-KE.properties (1)
374-384: Added missing DatabaseTable enum labels to fix Statistics → Database Export UI.The new enum mappings for database tables are properly formatted and consistent with existing entries. These additions directly address issue #13670 by providing labels for previously missing database table names in the export UI.
sormas-api/src/main/resources/enum_pt-CV.properties (2)
375-390: Add missing labels for database export feature — LGTM.The new
DatabaseTableentries (lines 375–385) andDateFilterOption.EPI_WEEK(line 389) follow the existing key=value format and Portuguese translation conventions. The arrow notation in "Events → Environments" (line 381) is consistent with similar hierarchical entries like "Contacts → Visits" (line 304). These additions directly address the missing labels reported in issue #13670 for the Statistics → Database Export section.
2465-2465: Re-added IMMUNIZATION_ANXIETY_RELATED classification label.The
AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATEDentry (line 2465) is properly restored with its Portuguese translation, maintaining consistency with other AEFI classification entries.sormas-api/src/main/resources/enum_uk-UA.properties (2)
374-384: Labels appear in English despite Ukrainian locale context.These new DatabaseTable enum entries are added to a Ukrainian (
uk-UA) locale properties file but use English captions ("System configuration values", "Notifier", etc.). This seems inconsistent with the file's intended purpose as a Ukrainian localization file.Please confirm whether:
- These captions should remain in English (if SORMAS intentionally uses English in Ukrainian locales for Database Export UI labels), or
- These should be translated to Ukrainian for proper localization support.
If translation is needed, you can open a follow-up issue to track Ukrainian translations for these newly exposed database table labels.
374-388: New enum entries follow existing patterns and address the reported issue.The additions correctly expose previously missing DatabaseTable and DateFilterOption labels that were blocking the Statistics → Database Export UI from displaying proper labels instead of raw field names. The property key format (
DatabaseTable.CONSTANT_NAME = Label) is consistent with existing entries throughout the file (e.g., line 296-373), and the arrow notation in line 380 matches similar relational entries (e.g., line 303Contacts → Visits).sormas-api/src/main/resources/enum_en-NG.properties (2)
375-385: New DatabaseTable enum labels properly formatted and integrated.The 11 new DatabaseTable entries follow the established naming and formatting conventions. Labels are descriptive and contextually appropriate for the Statistics → Database Export functionality. Placement and consistency with existing entries are correct.
To verify completeness of this PR, please confirm that:
- All 11 new DatabaseTable keys are defined in the corresponding backend enum class
- The same entries have been added to all 48 locale property files mentioned in the PR summary (consistent localization across languages)
389-389: DateFilterOption.EPI_WEEK addition correctly placed and formatted.The new entry follows the same naming pattern as
DateFilterOption.DATEand maintains label consistency ("By Epi Week" mirrors "By Date").sormas-api/src/main/resources/enum_fil-PH.properties (1)
374-384: LGTM! All new database table labels are properly formatted and consistent.The additions correctly provide user-facing labels for previously missing database table entries. The labels are descriptive, follow established naming conventions, and use appropriate conventions (e.g., arrow notation on line 380 to denote relationships, consistent with similar entries like line 303). The DateFilterOption addition on line 388 also follows the established pattern. No formatting, consistency, or clarity issues found.
Also applies to: 388-388
sormas-api/src/main/resources/enum_en-GH.properties (3)
375-385: Localized labels for missing DatabaseTable entries—directly addresses issue #13670.The 11 new entries provide appropriate, consistent captions for tables in the Statistics → Database Export feature:
- System configuration entries, notifiers, and drug susceptibility align with surveillance workflow.
- "Events → Environments" and adverse events entries follow established multi-entity relationship pattern (e.g., "Events → Event groups" on line 313).
- "Document related entities" is clear and actionable.
389-389: DateFilterOption.EPI_WEEK caption is consistent with existing enum pattern."By Epi Week" mirrors "By Date" on line 388, maintaining parallel structure and clarity for time-based filtering options.
2465-2465: Clarify intent: line 2465 appears to be a no-op formatting change.
AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATEDis marked as modified but does not appear related to issue #13670. Confirm whether this change is intentional or incidental to the database export label fixes.sormas-api/src/main/resources/enum_de-CH.properties (1)
2465-2465: Verify the English value for AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATED.Line 2465 re-adds
AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATED=Immunization anxiety relatedwith an English description. Confirm this is intentional, especially since adjacent AEFI-related entries in this file use either English or mixed-language values. If this field should be translated, provide a German translation consistent with the locale file's purpose.sormas-api/src/main/resources/enum_ps-AF.properties (2)
375-389: New DatabaseTable and DateFilterOption entries are properly formatted and complete.The 11 new DatabaseTable entries (lines 375-385) and DateFilterOption.EPI_WEEK (line 389) follow the existing pattern and conventions. The EVENT_ENVIRONMENTS label "Events → Environments" is consistent with the established relational naming pattern (cf. line 304).
However, verify whether English labels are appropriate for the Pashto (ps-AF) locale file, or if Pashto translations should be included. The existing content throughout the file appears to be English, suggesting this may be by design, but worth confirming to ensure consistency with the project's localization strategy.
2465-2465: Verify EVENT_ENVIRONMENTS caption alignment.Line 381 adds
DatabaseTable.EVENT_ENVIRONMENTS = Events → Environments. Confirm this caption change aligns with the UI requirements for Statistics → Database Export and that any previous labeling for this entry (if it existed) has been intentionally replaced.sormas-api/src/main/resources/enum_hi-IN.properties (1)
374-388: Localization concern: Hindi locale file contains English labels.The new DatabaseTable entries (lines 374-384) and DateFilterOption.EPI_WEEK (line 388) are added in English rather than Hindi translations. While this maintains consistency with the existing file (which is entirely in English), the file is designated as the Hindi locale (
hi-IN), so these entries should ideally be translated to Hindi for proper localization support.Verify whether this approach is intentional (serving as an English fallback for the Hindi locale) or if Hindi translations should be provided. If translations are needed, please ensure they are added to this file or confirm that they will be handled separately.
sormas-api/src/main/resources/enum_en-LR.properties (4)
375-385: ✓ Database table labels are appropriate and consistent.The new
DatabaseTableenum values follow the established naming convention with clear, user-friendly labels. The arrow notation used inEVENT_ENVIRONMENTS = Events → Environments(line 381) aligns with existing patterns for related entity relationships. All additions appear properly formatted and contextually appropriate for the Database Export feature.
388-389: ✓ DateFilterOption label follows established pattern.The
EPI_WEEKentry uses the consistent "By [criterion]" format, and "Epi Week" terminology aligns with existing usage throughout the file.
2462-2465: ✓ AefiClassificationSubType label is appropriate and consistent.The
IMMUNIZATION_ANXIETY_RELATEDentry follows the established naming pattern forAefiClassificationSubTypeand clearly describes the classification category.
375-385: Verify consistent updates across all 48 locale files.The AI summary indicates this PR updates enum entries across 48 locale-specific property files. Since only
enum_en-LR.propertiesis provided for review, please confirm that all other locale variants (e.g.,enum_en_GM.properties,enum_en_KE.properties, etc., and non-English locales) have received the same DatabaseTable, DateFilterOption, and AefiClassificationSubType additions.sormas-api/src/main/resources/enum_pt-BR.properties (4)
375-386: DatabaseTable enum translations correctly added for Database Export feature.The 11 new DatabaseTable entries are properly formatted and logically placed within the DatabaseTable section. Translations appear appropriate for Portuguese (Brazil), covering system configuration, notifier, drug susceptibility, special case accesses, environments, adverse events, and documents—all relevant to the Statistics → Database Export enhancement.
389-389: DateFilterOption.EPI_WEEK translation looks good.The entry is correctly positioned and the Portuguese translation is consistent with the pattern used for other date filter options.
2465-2465: AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATED properly restored.Formatting aligns with neighboring AEFI entries, and the translation is consistent with the semantic meaning of the enum value.
375-386: Verify translations are consistent across all 48 locale-specific property files.The AI summary indicates this PR modifies ~48 locale files in parallel. Please confirm that these same enum keys have been added with appropriately translated values across all other language variants (e.g.,
enum.properties,enum_de.properties, etc.). Since only this file is provided for review, the consistency of the broader PR cannot be fully validated.Also applies to: 389-389, 2465-2465
sormas-api/src/main/resources/enum_ar-SA.properties (3)
375-385: LGTM: DatabaseTable enum additions follow proper conventions and address the missing labels issue.The new entries for SYSTEM_CONFIGURATION_VALUES, SYSTEM_CONFIGURATION_CATEGORIES, NOTIFIER, DRUG_SUSCEPTIBILITY, SPECIAL_CASE_ACCESSES, ENVIRONMENTS, EVENT_ENVIRONMENTS, ADVERSE_EVENTS_FOLLOWING_IMMUNIZATIONS, ADVERSE_EVENTS_FOLLOWING_IMMUNIZATION_INVESTIGATIONS, ADVERSE_EVENTS, and DOCUMENT_RELATED_ENTITIES are correctly formatted and provide localized labels that will resolve the missing labels in Statistics → Database Export.
The formatting and structure are consistent with existing DatabaseTable entries (e.g., line 304's
CONTACTS_VISITS = Contacts → Visits).Since this change spans 48 locale property files, verify that all locale files have been updated consistently with the same enum keys and semantically equivalent labels across locales.
388-389: LGTM: DateFilterOption.EPI_WEEK addition is properly formatted and consistent.The new
DateFilterOption.EPI_WEEK = By Epi Weekentry mirrors the existing pattern of line 388 (DateFilterOption.DATE = By Date) and follows the same naming and translation convention.
2465-2465: LGTM: AefiClassificationSubType entry is properly formatted.The line is syntactically correct and follows the established pattern for enum translations.
sormas-api/src/main/resources/enum_de-DE.properties (1)
389-389: DateFilterOption.EPI_WEEK properly translated.This entry is correctly translated to German ("Nach Epi Woche").
sormas-api/src/main/resources/enum_fa-AF.properties (3)
375-385: Verify the language of enum values matches the fa-AF locale intent.The newly added DatabaseTable entries (lines 375–385) contain English labels, but this file is named
enum_fa-AF.properties, which should contain Persian (Dari) translations for Afghanistan locale. All other existing entries in this file also appear to be in English.Confirm whether:
- English labels in fa-AF locale files are intentional (e.g., fallback behavior or design choice),
- These translations were supposed to be in Persian/Dari but were inadvertently added in English across all 48 locale files mentioned in the summary.
If Persian translations are required, this would affect all 11 new DatabaseTable entries and the DateFilterOption entry added in this PR.
375-389: Enum entry formatting and placement look correct.The new DatabaseTable entries (lines 375–385) are properly formatted following the
EnumType.ENUM_VALUE = Labelpattern and are correctly inserted within the existing DatabaseTable section. The DateFilterOption.EPI_WEEK entry (line 389) is appropriately placed after DateFilterOption.DATE, maintaining consistent structure.
2465-2465: Clarify the purpose of re-adding AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATED.Line 2465 is marked as a changed line (with
~) and containsAefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATED=Immunization anxiety related. According to the enriched summary, this entry was "deleted and re-added with the same value (no net semantic change)" in some files.Confirm whether this re-add is:
- Intentional and necessary (e.g., addressing a file order/formatting issue),
- A version control artifact that should be cleaned up, or
- Part of the broader enum expansion in this PR.
sormas-api/src/main/resources/enum_ru-RU.properties (2)
375-385: Localization concern: File contains English values despite Russian locale filename.This file is named
enum_ru-RU.properties(indicating Russian locale), but all the new entries and existing entries throughout the file contain English text rather than Russian translations. For example:
- Line 375:
SYSTEM_CONFIGURATION_VALUES = System configuration values(English)- Line 389:
DateFilterOption.EPI_WEEK = By Epi Week(English)- Line 2465:
AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATED=Immunization anxiety related(English)This pattern is consistent throughout the file, but warrants clarification: is this intentional (technical terms remain in English while UI localization happens elsewhere), or should these entries be translated to Russian?
Please confirm whether:
- Russian translations should be provided in this file, or
- English is intentional for technical enum labels in all locales, or
- If this is a fallback/default file that gets supplemented by actual Russian translations elsewhere
Once clarified, if Russian translations are needed, they should be added to ensure full localization for Russian-speaking users in the Statistics → Database Export feature.
Also applies to: 389-389, 2465-2465
375-385: Formatting and syntax of new DatabaseTable entries is consistent.The 11 new DatabaseTable entries (lines 375–385) follow proper properties file syntax and match the existing naming conventions:
- Correct key=value format with
DatabaseTable.prefix- Appropriate use of arrow notation for relationships (e.g.,
Events → Environments)- Alignment with existing DatabaseTable entries (lines 297–374)
sormas-api/src/main/resources/enum_pl-PL.properties (1)
375-389: Additions address the missing labels issue correctly.All 11 new
DatabaseTableentries and the newDateFilterOption.EPI_WEEKentry are present with appropriate, clear captions. The formatting is consistent with existing entries (e.g., composite relationships use the arrow notation like line 313: "Events → Event groups"). The captions are reasonable and will provide human-readable labels instead of raw field names in the Database Export UI.sormas-api/src/main/resources/enum_fr-TN.properties (1)
389-389: DateFilterOption.EPI_WEEK is correctly translated.Line 389 properly translates the new DateFilterOption to French (
Par semaine= "By week"), consistent with existing localization in the file.sormas-api/src/main/resources/enum_it-CH.properties (3)
375-385: LGTM: DatabaseTable labels added correctly for Database Export UI.The 11 new
DatabaseTableenum entries follow the existing pattern and properly address the missing labels in the Statistics → Database Export feature. The English labels for system configuration and related tables are consistent with how table names are handled elsewhere in the codebase.
388-389: DateFilterOption.EPI_WEEK translation is consistent across locales.The Italian translation "Per settimana Epi" for the EPI_WEEK filter option is properly localized and matches the equivalent entry in the parallel IT-IT file, maintaining good consistency across Swiss and Italian locales.
2465-2465: Verify AefiClassificationSubType line is not a removal/re-add.Line 2465 shows
AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATED=Immunization anxiety relatedmarked as a change. Confirm this is a line repositioning (formatting adjustment) and not unintentionally removing and re-adding the entry, which could affect parsing or cause version control issues.sormas-api/src/main/resources/enum_it-IT.properties (2)
375-385: DatabaseTable entries are correctly mirrored from IT-CH locale.The 11 new
DatabaseTableentries in the IT-IT file match identically with the IT-CH file, maintaining consistency across Italian locales. This parallel structure is appropriate for the base labels that do not require locale-specific variation.
388-389: DateFilterOption.EPI_WEEK maintains consistency across all locales.The Italian translation "Per settimana Epi" is identical in both IT-CH and IT-IT files, confirming a consistent user experience across Swiss Italian and Italian-speaking regions.
sormas-api/src/main/resources/enum_nl-NL.properties (2)
387-388: DateFilterOption entries added.Both
DATEandEPI_WEEKfilter options are properly localized with clear, user-friendly Dutch labels.
374-384: All new DatabaseTable and DateFilterOption entries are properly defined and correctly localized.Verified that all 11 DatabaseTable enum values (SYSTEM_CONFIGURATION_VALUES, SYSTEM_CONFIGURATION_CATEGORIES, NOTIFIER, DRUG_SUSCEPTIBILITY, SPECIAL_CASE_ACCESSES, ENVIRONMENTS, EVENT_ENVIRONMENTS, ADVERSE_EVENTS_FOLLOWING_IMMUNIZATIONS, ADVERSE_EVENTS_FOLLOWING_IMMUNIZATION_INVESTIGATIONS, ADVERSE_EVENTS, DOCUMENT_RELATED_ENTITIES) and both DateFilterOption values (DATE, EPI_WEEK) are properly defined in their respective Java enum classes. The properties file entries follow the correct format and are consistent with existing patterns.
sormas-api/src/main/resources/enum_ur-PK.properties (3)
389-389: Proper localization for DateFilterOption.EPI_WEEK.The EPI_WEEK entry is correctly translated to Urdu ("EPI ہفتہ کے مطابق"), maintaining consistency with surrounding entries.
2465-2465: Localization mismatch: AefiClassificationSubType value is in English.Line 2465 uses an English value ("Immunization anxiety related") while the property key suggests it should follow the pattern of other AefiClassificationSubType entries in this section (lines 2462-2464), which use English values as well. This appears consistent with the AEFI section pattern, but verify if this entry needs a Urdu translation like other enum entries earlier in the file.
375-385: These English labels are intentional across all locale files, not a Urdu-specific inconsistency.The 11 DatabaseTable entries in English (SYSTEM_CONFIGURATION_VALUES, NOTIFIER, DRUG_SUSCEPTIBILITY, etc.) are consistently in English across all 45+ locale files in the codebase, including German, French, Spanish, Russian, Chinese, Japanese, and others. This is a system-wide pattern, not a localization error unique to the Urdu locale. These entries appear to be untranslated placeholders added as new database table additions that will likely be translated later as part of a coordinated effort across all supported languages.
Likely an incorrect or invalid review comment.
sormas-api/src/main/resources/enum_sv-SE.properties (1)
374-384: New DatabaseTable entries complete and properly formatted.The 11 new DatabaseTable entries follow the correct properties file syntax and are consistent with existing entry patterns (capitalization, label structure). The arrow notation (→) in the "Events → Environments" label aligns with similar entries elsewhere in the file (e.g., "Events → Event groups", "Contacts → Visits").
sormas-api/src/main/resources/enum_pt-PT.properties (1)
374-384: Localization additions are properly integrated and aligned with enum definitions.All 11 new DatabaseTable entries are correctly formatted, follow existing naming conventions, and include the appropriate hierarchical notation. The entries exist in the Java DatabaseTable enum, are consistent across all 89 complete locale files, and are properly integrated into the i18n system. No issues detected.
sormas-api/src/main/resources/enum_en-GM.properties (2)
375-385: Labels properly added for Statistics → Database Export feature. The newDatabaseTableentries are well-formatted and appropriately labeled for database export/statistics use. All entries follow the established capitalization and naming conventions (e.g., line 381 "Events → Environments" correctly uses the arrow notation pattern seen in similar entries). Placement is logical and doesn't disrupt the existing enum structure.
389-389: EPI_WEEK filter option added correctly.DateFilterOption.EPI_WEEKis properly positioned between the existingDateFilterOption.DATEentry and the next section. The label "By Epi Week" maintains consistency with the established capitalization pattern ("By Date").sormas-api/src/main/resources/enum_ja-JP.properties (2)
388-388: DateFilterOption.EPI_WEEK addition is correct.The entry is properly positioned within the DateFilterOption section and follows the consistent format with the existing
DATEoption on line 387. The translation "By Epi Week" is semantically aligned with the by-date option.
374-384: New DatabaseTable entries properly formatted and consistently applied across all 52 locale files.All 11 new DatabaseTable enum entries (SYSTEM_CONFIGURATION_VALUES, SYSTEM_CONFIGURATION_CATEGORIES, NOTIFIER, DRUG_SUSCEPTIBILITY, SPECIAL_CASE_ACCESSES, ENVIRONMENTS, EVENT_ENVIRONMENTS, ADVERSE_EVENTS_FOLLOWING_IMMUNIZATIONS, ADVERSE_EVENTS_FOLLOWING_IMMUNIZATION_INVESTIGATIONS, ADVERSE_EVENTS, and DOCUMENT_RELATED_ENTITIES) are correctly defined in the DatabaseTable enum. The additions follow proper formatting conventions, are logically grouped with existing database table definitions, and the line 380 entry (EVENT_ENVIRONMENTS = Events → Environments) appropriately uses arrow notation consistent with similar relationship mappings. Parallel updates have been applied consistently across all 52 locale property files.
sormas-api/src/main/resources/enum_fi-FI.properties (2)
388-389: Inconsistent locale coverage: DateFilterOption.EPI_WEEK correctly translated, but context unclear.Line 389 correctly provides a Finnish translation (
Epidemiaviikon mukaan), yet the DatabaseTable entries (lines 375–385) above remain in English. This highlights an uneven translation effort.Clarify the translation status: are the DatabaseTable entries awaiting Finnish translations, or is there a deliberate reason to leave them untranslated in the Finnish locale file?
375-385: The review comment is incorrect. Lines 375–385 follow the established pattern in the codebase where database table names are kept in English across all locale files, not a translation oversight.Evidence:
- The same entries (
SYSTEM_CONFIGURATION_VALUES,NOTIFIER,DRUG_SUSCEPTIBILITY, etc.) are identically untranslated in German, Spanish, Portuguese, and Italian locale files- The Finnish file itself contains dozens of other DatabaseTable entries in English (e.g.,
CUSTOMIZABLE_ENUM_VALUES,EVENT_GROUPS,PATHOGEN_TESTS,MATERNAL_HISTORIES), mixed with some translated entries- This is a systemic design choice where database table names are preserved as English technical terms across all 48 locale files, not an incomplete PR
No action is required on these entries. They are working as designed.
Likely an incorrect or invalid review comment.
sormas-api/src/main/resources/enum_cs-CZ.properties (2)
389-389: Approved: DateFilterOption.EPI_WEEK translation.The Czech translation for
EPI_WEEKis properly localized as "Podle týdne Epi" (By Epi week).
2465-2465: Approved: AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATED translation.The Czech translation for
IMMUNIZATION_ANXIETY_RELATEDis properly localized as "související s obavami z imunizace" (related to immunization anxiety).sormas-api/src/main/resources/enum_ro-RO.properties (1)
374-388: The entireenum_ro-RO.propertiesfile is in English, not just the newly added entries.The review comment assumes existing entries like
DatabaseTable.CASES = CazuriandDatabaseTable.EVENTS = Evenimenteare already translated to Romanian, but they are not. The actual file containsDatabaseTable.CASES = Cases(English, not Romanian). All entries throughout the file—both pre-existing and new—are in English. This is a broader localization issue affecting the entire file, not a problem specific to lines 374–388. If Romanian translations are required, the entire file requires translation, not just the newly added entries.Likely an incorrect or invalid review comment.
sormas-api/src/main/resources/enum_es-BO.properties (1)
2462-2465: AefiClassificationSubType entry is consistent and harmless
AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATEDmatches the naming and style of the other AEFI subtype captions and doesn’t introduce any behavioral change; it’s fine as is.sormas-api/src/main/resources/enum.properties (1)
408-418: DatabaseTable additions are consistent and address DB export labelingThe new
DatabaseTable.*captions for system configuration, notifier, drug susceptibility, special case accesses, environments, AEFI-related tables, adverse events, and document-related entities are consistent with existing naming and will allow these tables to show meaningful labels (incl.EVENT_ENVIRONMENTS = Events → Environments) in the Statistics → Database Export UI instead of raw enum names. No issues from my side.sormas-api/src/main/resources/enum_fj-FJ.properties (1)
374-388: Missing enum labels correctly added for Database Export feature.The 11 new
DatabaseTableentries (lines 374–384) andDateFilterOption.EPI_WEEK(line 388) are properly formatted, consistently placed, and directly address the missing labels reported in issue #13670. Labels follow established naming conventions (e.g.,EVENT_ENVIRONMENTS = "Events → Environments"), and the additions will populate the Statistics → Database Export dropdown with appropriate human-readable options.sormas-api/src/main/resources/enum_lv-LV.properties (1)
374-388: Locale-consistent enum label additions mirror Fijian file.The 11 new
DatabaseTableentries (lines 374–384) andDateFilterOption.EPI_WEEK(line 388) are identical to the Fijian locale file, maintaining consistency across locales. Placement, formatting, and label text align with the established pattern in the codebase. These changes provide the missing UI labels for the Database Export dropdown.sormas-api/src/main/resources/enum_ne-NP.properties (2)
374-384: DatabaseTable enum entries added correctly with proper formatting.The 11 new DatabaseTable entries follow the established enum naming convention and file structure. The relational notation (e.g., "Events → Environments") is consistent with similar entries elsewhere in the file (e.g., line 303).
387-388: DateFilterOption entries added with correct structure.The DATE and EPI_WEEK filter options are properly formatted and positioned. Note that values remain in English, which is consistent with the rest of this locale file.
sormas-api/src/main/resources/enum_es-EC.properties (2)
369-379: DatabaseTable additions present and properly formatted; translation completeness may vary.The 11 DatabaseTable entries match those in the Nepali locale file. Some entries retain English labels (e.g., "Notifier", "Drug susceptibility") while others are translated to Spanish. This pattern is consistent with existing entries in the file where technical terms may be left in English.
382-383: DateFilterOption entries properly translated to Spanish.Both DATE and EPI_WEEK filter options include appropriate Spanish translations ("Por fecha" and "Por semana EPI"). Formatting and structure are consistent with the rest of the file.
sormas-api/src/main/resources/enum_en-KE.properties (1)
375-385: Additions are well-placed and follow existing conventions.The new DatabaseTable entries (lines 375-385) and DateFilterOption.EPI_WEEK (line 389) are correctly positioned within the enum hierarchy and use consistent formatting. These additions directly address issue #13670 by providing missing labels for the Database Export UI. Labels are appropriately generic English terms suitable for all English locales.
Also applies to: 389-389
sormas-api/src/main/resources/enum_tr-TR.properties (1)
374-384: Additions are consistent with en-KE counterpart.The new DatabaseTable entries and DateFilterOption.EPI_WEEK match the en-KE file identically, maintaining parity across locale files for these changes.
Also applies to: 388-388
sormas-api/src/main/resources/enum_fr-CD.properties (2)
387-389: DateFilterOption.EPI_WEEK addition appears untranslated.Line 389 adds
DateFilterOption.EPI_WEEK = By Epi Weekin English. Verify whether this key should have a French translation in enum_fr-CD.properties (e.g.,À la Semaine de l'Epias appears in enum_fr-CH.properties line 389).
374-384: DatabaseTable entries in enum_fr-CD.properties lack French translations, creating inconsistency with other French locale files.The new DatabaseTable entries (SYSTEM_CONFIGURATION_VALUES, NOTIFIER, DRUG_SUSCEPTIBILITY, ENVIRONMENTS, ADVERSE_EVENTS, and others) are in English in enum_fr-CD.properties. In contrast, enum_fr-CH.properties provides French translations for corresponding DatabaseTable entries (e.g.,
CASES = Les cas,CLINICAL_COURSES = Cours clinique,DISTRICTS = Departement), demonstrating that localization is expected for this enum type.Note: enum_fr-CD.properties shows a broader pattern where most existing DatabaseTable entries also remain in English, while enum_fr-CH.properties has partial French translations. Clarify whether this reflects intentional locale-specific translation completeness or incomplete translation work.
sormas-api/src/main/resources/enum_fr-CH.properties (2)
388-389: DateFilterOption.EPI_WEEK is correctly translated to French.Line 389 shows
DateFilterOption.EPI_WEEK = À la Semaine de l'Epi, which is a proper French translation. This entry is appropriately localized, contrasting with the untranslated DatabaseTable entries.
375-385: These DatabaseTable entries are untranslated across all language files, not just French-CH.The 11 entries at lines 375–385 (SYSTEM_CONFIGURATION_VALUES, NOTIFIER, DRUG_SUSCEPTIBILITY, etc.) remain in English in enum_fr-CH.properties, but the same applies to enum_fr-FR.properties, enum_de-CH.properties, enum_de-DE.properties, and other language variants. This is a consistent, system-wide pattern, not a French-CH-specific localization gap.
Earlier DatabaseTable entries (EXPORT_CONFIGURATIONS, FEATURE_CONFIGURATIONS) are sometimes translated in other language files (e.g., "Configurations d'exportation" in French FR), but these new entries are uniformly untranslated across all locales. This suggests the entries are either pending translation globally or intentionally retained as English technical identifiers.
Likely an incorrect or invalid review comment.
sormas-api/src/main/resources/enum_en-AF.properties (1)
375-389: Comprehensive enum additions for Database Export labels.The new DatabaseTable entries and DateFilterOption.EPI_WEEK additions are well-formed and follow the existing property file conventions. These entries directly address issue #13670 by exposing previously missing labels in the Statistics → Database Export feature.
Line 381 (
DatabaseTable.EVENT_ENVIRONMENTS = Events → Environments) uses an arrow notation that is consistent with similar multi-level entries (e.g., line 313EVENTS_EVENTGROUPS), so the formatting is appropriate.sormas-api/src/main/resources/enum_es-ES.properties (1)
374-388: Translation completeness: Verify Spanish localization for new DatabaseTable entries.The Spanish (ES) locale file includes the same 11 new DatabaseTable entries and DateFilterOption.EPI_WEEK as the English (AF) variant, maintaining consistency. However, all newly added labels remain in English (e.g., "Notifier", "Drug susceptibility", "System configuration values"), while other enum values in this same file do contain Spanish translations (e.g., "Español (Ecuador)" at line 892, and disease names like "Viruela del mono").
Clarification needed: Are these English-language labels intentional for the Spanish (Spain) locale, or should they be translated to Spanish? Examples of expected translations might include:
- "Notifier" → "Notificador"
- "System configuration values" → "Valores de Configuración del Sistema"
- "Drug susceptibility" → "Susceptibilidad a Medicamentos"
Please confirm whether the Spanish translations exist in other modified files, or whether these entries should be left in English for technical reasons.
sormas-api/src/main/resources/enum_es-CU.properties (1)
389-389: ✓ EPI_WEEK translation is correct.The DateFilterOption.EPI_WEEK entry has been properly translated to Spanish ("Por semana epi").
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13784 |
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (1)
sormas-api/src/main/resources/enum_de-DE.properties (1)
2462-2465: AefiClassificationSubType captions still English in de-DEThe new
AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATEDvalue is English, as are the three existing subtype captions above it. For a German locale file you may want to translate all four in a follow-up (e.g. “impfstoffbezogen”, “Qualitätsmangel am Impfstoff”, “Immunisierungsfehlerbedingt”, “Impfangstbezogen” or similar), but this is not a blocker for the current DB-export label fix.
🧹 Nitpick comments (3)
sormas-api/src/main/resources/enum_zu-ZA.properties (1)
287-297: Consider completing Zulu language translations.This file is labeled as
enum_zu-ZA.properties(Zulu/South Africa locale) but currently contains English labels throughout. While this follows the existing pattern in the file and provides functional labels, it may be worth planning actual Zulu translations as a follow-up to improve localization completeness. This applies both to these newly added entries and the existing ones in the file.sormas-api/src/main/resources/enum_fr-CH.properties (1)
389-389: Minor suggestion: Consider more natural French phrasing for EPI_WEEK.The translation "À la Semaine de l'Epi" is understandable but slightly unconventional. The existing pattern in the file uses "Par semaine épidémiologique" (line 649), which may be more idiomatic. Consider whether consistency with established terminology would improve user experience.
sormas-api/src/main/resources/enum_de-CH.properties (1)
2462-2465: AefiClassificationSubType entry is consistent with existing block
AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATEDuses an English caption, but this matches the existing AefiClassificationSubType entries in this file. Leaving it as-is is acceptable for this PR; full localization of this block can be handled separately if desired.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (18)
sormas-api/src/main/resources/enum_ar.propertiessormas-api/src/main/resources/enum_de-CH.propertiessormas-api/src/main/resources/enum_de-DE.propertiessormas-api/src/main/resources/enum_es-BO.propertiessormas-api/src/main/resources/enum_es-CU.propertiessormas-api/src/main/resources/enum_es-EC.propertiessormas-api/src/main/resources/enum_es-ES.propertiessormas-api/src/main/resources/enum_fr-CD.propertiessormas-api/src/main/resources/enum_fr-CH.propertiessormas-api/src/main/resources/enum_fr-FR.propertiessormas-api/src/main/resources/enum_fr-TN.propertiessormas-api/src/main/resources/enum_haw-US.propertiessormas-api/src/main/resources/enum_ks-PK.propertiessormas-api/src/main/resources/enum_ku-TR.propertiessormas-api/src/main/resources/enum_la-LA.propertiessormas-api/src/main/resources/enum_mt-MT.propertiessormas-api/src/main/resources/enum_tr-TR.propertiessormas-api/src/main/resources/enum_zu-ZA.properties
🚧 Files skipped from review as they are similar to previous changes (2)
- sormas-api/src/main/resources/enum_es-CU.properties
- sormas-api/src/main/resources/enum_fr-CD.properties
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: SORMAS CI
- GitHub Check: android app test (28)
- GitHub Check: android app test (26)
- GitHub Check: android app test (27)
🔇 Additional comments (28)
sormas-api/src/main/resources/enum_tr-TR.properties (1)
375-385: ✓ Localization entries properly structured and positioned.The 11 new DatabaseTable localization keys are correctly formatted, well-positioned at the end of the DatabaseTable section, and directly address the missing labels issue #13670. All translations follow the established pattern and precede the DateFilterOption section as expected.
sormas-api/src/main/resources/enum_es-ES.properties (2)
374-384: ✓ Spanish translations added for missing database table labels.The additions provide appropriate Spanish labels for the database export statistics tables, directly addressing the missing labels issue. Translations are semantically accurate and follow the existing format.
Since the PR summary mentions changes across multiple locale property files, please verify that equivalent keys have been added to all relevant locale files (e.g.,
enum_en.properties,enum_de.properties, etc.) to ensure consistency across all supported languages.
388-388: ✓ DateFilterOption.EPI_WEEK added to Spanish locale.The entry correctly adds the Epi Week filter option label in Spanish. This complements the earlier localization additions.
sormas-api/src/main/resources/enum_mt-MT.properties (1)
287-301: Localization additions look good and directly address the missing labels issue.All 11 new
DatabaseTableentries (lines 287–297) and theDateFilterOption.EPI_WEEKentry (line 301) are properly formatted, follow the existing key=value pattern, and provide clear, descriptive labels for database tables previously missing from the Statistics → Database Export UI. The labels are consistent with the file's existing style.One observation: The labels are in English despite the file being named for the Maltese (MT) locale. If this file is intended to be translated to Maltese, translations should be added; however, if it serves as a fallback/default locale, the current approach is acceptable.
sormas-api/src/main/resources/enum_ar.properties (2)
205-215: Syntax and formatting are correct.The 11 new DatabaseTable entries follow the established key=value pattern and are properly positioned within the DatabaseTable section. Entry names adhere to the enum naming convention.
However, verify that all required locale property files (not just the Arabic locale shown here) also include these same keys, as the AI summary indicates changes across many locale files.
219-219: DateFilterOption.EPI_WEEK placement is correct.The new entry is properly positioned after DateFilterOption.DATE and follows the existing value format.
sormas-api/src/main/resources/enum_zu-ZA.properties (2)
287-297: Localization keys correctly added for missing DatabaseTable enums.The 11 new DatabaseTable enum entries follow the proper naming convention and format established in the file. All entries are appropriately placed within the DatabaseTable section and correspond to the missing labels reported in issue #13670 (Statistics → Database Export).
301-301: DateFilterOption.EPI_WEEK addition is properly formatted.The addition of
DateFilterOption.EPI_WEEK = By Epi Weekat line 301 follows the existing pattern and aligns with the AI-generated summary noting this was added across multiple locales.sormas-api/src/main/resources/enum_fr-TN.properties (2)
375-385: French translations for DatabaseTable entries successfully added—resolves prior review feedback.The 11 missing DatabaseTable enum entries have been properly translated to French, addressing the critical localization gap flagged in the previous review. Translations follow the established patterns and terminology in the file (e.g., "Événements indésirables", "Enquêtes", "Environnements").
389-389: DateFilterOption.EPI_WEEK properly localized.French translation ("Par semaine") is consistent with similar date-related entries in the file (e.g., line 388).
sormas-api/src/main/resources/enum_fr-CH.properties (3)
375-385: ✓ Correct localization additions addressing missing labels.The 11 new DatabaseTable enum entries provide French translations for the missing labels reported in issue #13670, directly supporting the Database Export statistics feature. All translations appear linguistically appropriate for French-Swiss locale.
294-294: ✓ DashboardType translation properly added.Updated translation from English "Adverse Events" to French "Événements indésirables" maintains consistency with FR-CH locale formatting.
2465-2465: Translation missing for IMMUNIZATION_ANXIETY_RELATED.Line 2465 shows an English value ("Immunization anxiety related") rather than a French translation, inconsistent with the FR-CH locale. While the AI summary notes this was "re-added after removal," verify whether this requires a French translation to maintain locale consistency, or if English retention is intentional per project conventions.
sormas-api/src/main/resources/enum_haw-US.properties (1)
287-297: LGTM! Labels are appropriate and resolve missing UI elements.The 11 new
DatabaseTablelocalizations are well-written, follow the file's naming conventions (human-readable English labels), and directly address the issue of missing labels in the Statistics → Database Export feature. The label "Events → Environments" forEVENT_ENVIRONMENTSappropriately indicates the hierarchical relationship.sormas-api/src/main/resources/enum_fr-FR.properties (2)
388-389: Adds DateFilterOption.EPI_WEEK entry for date filtering.The addition of
DateFilterOption.EPI_WEEK = Par semainefollows the existing pattern and provides the French translation for epidemiological week-based filtering.
2465-2465: AefiClassificationSubType.IMMUNIZATION_ANXIETY_RELATED is reordered.Per the AI summary, this entry appears to be repositioned rather than modified semantically. The English text remains unchanged: "Immunization anxiety related". Confirm this is intentional (some enum values in the AEFI section remain in English rather than French).
sormas-api/src/main/resources/enum_ku-TR.properties (1)
308-318: Missing enum labels resolved correctly.The 11 new DatabaseTable enum mappings (lines 308-318) are properly formatted and address the reported issue of missing labels in Statistics → Database Export. All entries follow the existing pattern with English labels consistent with other entries in this file, and have been comprehensively added to locale files across the system.
sormas-api/src/main/resources/enum_es-EC.properties (3)
369-379: DatabaseTable enum additions are well-formed and consistent.All 11 new DatabaseTable keys are properly added with contextually appropriate Spanish translations. Terminology aligns with existing patterns in the file (e.g., "Ambientes," "Notificador," "Entidades relacionadas con documentos"). No syntax errors detected.
382-383: DateFilterOption entries are correctly positioned and spelled.DATE and EPI_WEEK entries follow the established format and naming convention used elsewhere in the file (consistent with lines 617-619 EpiCurveGrouping pattern).
369-389: Locale file consistency verification complete — all required keys are present across all 52 supported locale files.The 11 DatabaseTable keys, DateFilterOption keys, and DeathPlaceType keys have been applied uniformly across all supported locales, including es-EC, es-BO, and all other language variants. No inconsistencies or missing labels were found.
sormas-api/src/main/resources/enum_es-BO.properties (2)
375-385: DatabaseTable enum additions mirror es-EC file with identical translations.All 11 DatabaseTable keys are correctly added with translations matching the es-EC locale file. Proper formatting and no syntax errors detected.
388-389: DateFilterOption entries are correctly added.DATE and EPI_WEEK options follow the established pattern and are consistent with the es-EC file.
sormas-api/src/main/resources/enum_de-CH.properties (1)
375-385: DatabaseTable translations look consistent and appropriateThe new DatabaseTable captions are properly localized to (Swiss-)German and aligned with the surrounding entries and terminology. No further changes needed here.
sormas-api/src/main/resources/enum_de-DE.properties (1)
375-385: New DatabaseTable and DateFilterOption entries are well-localizedThe added DatabaseTable captions and
DateFilterOption.EPI_WEEKare correctly translated to German and consistent with existing terminology in this file and with other locales. This should fix the missing labels in the Statistics → Database Export view.Also applies to: 387-389
sormas-api/src/main/resources/enum_ks-PK.properties (1)
287-301: New DatabaseTable and DateFilterOption entries align with existing ks-PK localeThe added DatabaseTable keys and
DateFilterOption.EPI_WEEKuse clear English captions consistent with the rest of this file and other locales. They should correctly surface the previously missing labels in the Database Export UI.sormas-api/src/main/resources/enum_la-LA.properties (3)
287-297: DatabaseTable enum entries are well-formatted and semantically clear.The 11 new DatabaseTable entries follow the established naming and labeling conventions. Labels are concise, descriptive, and use title case consistently. The EVENT_ENVIRONMENTS label appropriately uses the arrow notation ("Events → Environments") to indicate a hierarchical relationship, which aligns with the UI context (Statistics → Database Export).
301-301: DateFilterOption.EPI_WEEK addition is syntactically correct.The new entry follows the existing pattern for DateFilterOption enums and is consistently placed within the DateFilterOption section.
287-301: Add Language.LA enum constant to Language.java to match the new enum_la-LA.properties locale file.The locale code "la-LA" (Latin) has been added to 56 enum property files (except enum_en.properties, which is intentionally a legacy master file). However, it's missing from the Language enum in
sormas-api/src/main/java/de/symeda/sormas/api/Language.java. Without this definition, the localization system won't recognize "la-LA" as a valid language and will fail at runtime. Add Language.LA with an appropriate Locale("la") definition to Language.java to complete the localization support.
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13784 |
Fixes #13670
Summary by CodeRabbit
New Features
Localization
Tweaks
✏️ Tip: You can customize this high-level summary in your review settings.