Drop stringstream#1347
Open
vadz wants to merge 5 commits into
Open
Conversation
Use SOCI cstring_to_xxx() functions for consistency with the other backends and because they should also be more slightly more efficient.
Use SOCI cstring_to_integer() instead of std::istringstream and throw an exception if an invalid value is specified for this parameter.
Just small clean up: don't use stringstream when we really need just an ostringstream.
Use fmt::format() to build them directly instead, this is much simpler. Also get rid of useless and trivial check_sqlite_err() function to simplify the code a bit more.
Check for ERANGE which is the only way to detect a value out of range of long long type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove almost all remaining uses of
std::stringstream.