Skip to content

Conversation

@tbwester
Copy link
Contributor

@tbwester tbwester commented Mar 4, 2025

It is sometimes useful to exclude hits with poor fits when doing analysis with the calibration ntuples. This PR adds a field to store the recob::Hit::GoodnessOfFit score to the sbn::HitInfo object so that it is available in the calibration ntuples. See corresponding PR in sbncode for implementation in TrackCaloSkimmer_module.cc.

Associated sbncode PR: SBNSoftware/sbncode#512

@tbwester tbwester added the enhancement New feature or request label Mar 4, 2025
@kjplows kjplows moved this to Partially reviewed in SBN software development Mar 6, 2025
Copy link

@mrmooney mrmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A useful addition, and the implementation looks fine.

@kjplows kjplows moved this from Partially reviewed to Testing in SBN software development Mar 10, 2025
@kjplows
Copy link
Contributor

kjplows commented Mar 10, 2025

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Mar 10, 2025
@kjplows kjplows merged commit d813800 into develop Mar 17, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Mar 17, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Mar 17, 2025
@tbwester tbwester deleted the feature/twester_gaushit_info branch March 17, 2025 16:48
@kjplows kjplows moved this from Recently done to Done in SBN software development Mar 27, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the v10_04_06 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

7 participants