Skip to content

Conversation

@nathanielerowe
Copy link
Contributor

Fixes #479, restructures code so SBND BNB modules and ICARUS BNB modules can share some code. Open to feedback on the best way to handle this, since I did not write the original BNBRetriever module.

sjgardiner and others added 30 commits July 26, 2024 20:11
SBNEventWeight differences. Also make some adjustments to get it to build
against geant4reweight v01_00_03e -q e20:s120a:prof
* Placeholder for sampled parameter storage, for CAF compatibility.
* Renamed fcl for consistency
@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Urgent checks to To merge in SBN software development Sep 2, 2025
@kjplows kjplows merged commit 0ad5ec1 into develop Sep 12, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Sep 12, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Sep 12, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Sep 18, 2025
@nathanielerowe nathanielerowe deleted the feature/icarus_bnb_only branch October 22, 2025 03:43
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the v10_10_02 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Addresses one or more bugs maintenance

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

BNBRetriever Cache Bug