Skip to content

Conversation

@kjplows
Copy link
Contributor

@kjplows kjplows commented Feb 6, 2025

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.

This PR changes the way the GENIE EventRecord is stored in flat CAFs. Instead of storing the entire genie::EventRecord (as is done in the regular CAF), the information of the EventRecord is saved as C-style arrays. The convention follows that of the GENIE rootracker format.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@kjplows kjplows added the refactor Something needing refactoring label Feb 6, 2025
@kjplows kjplows self-assigned this Feb 6, 2025
Copy link
Contributor

@jedori0228 jedori0228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kjplows ! Just tested this PR and seeing the flattened GENIE trees in the flatcaf output.

@ibsafa ibsafa merged commit 2950670 into develop Feb 14, 2025
@bear-is-asleep bear-is-asleep moved this from In Develop to In tagged release in SBND March 2025 production Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Something needing refactoring

Projects

Status: Done
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

5 participants