Fix of segfault in cluster3d #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry service. Put this back in, also modified the loop over TPCIDs to loop over TPCgeos. The latter might not be necessary but is safe...
ibsafa
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A segfault was reported in Cluster3D in larsoft v10 testing. Traced to SnippitHit3DBuilderSBN where it was found that the move to v10 had removed the initialization of the geometry service. Restored this and also modifed the loop over TPCIDs (where the segfault was occuring since taht was the first use of the geometry service) to iterate over TPCGeo. Confirmed that it is running again.