-
Notifications
You must be signed in to change notification settings - Fork 35
SBNB POT Accounting Producer Modules #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removing some debugging lines
Removing leftover debugging lines
jzennamo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would would be good to verify that this is doing what we expect it to do with data. Both running the modules and seeing if we can co-normalize the samples but also what happens when we run modules on the "wrong" sample?
sbncode/BeamSpillInfoRetriever/SBNDBNBEXTRetriever/SBNDBNBEXTRetriever_module.cc
Outdated
Show resolved
Hide resolved
sbncode/BeamSpillInfoRetriever/SBNDBNBEXTRetriever/SBNDBNBEXTRetriever_module.cc
Outdated
Show resolved
Hide resolved
sbncode/BeamSpillInfoRetriever/SBNDBNBRetriever/SBNDBNBRetriever_module.cc
Outdated
Show resolved
Hide resolved
sbncode/BeamSpillInfoRetriever/SBNDBNBRetriever/SBNDBNBRetriever_module.cc
Outdated
Show resolved
Hide resolved
sbncode/BeamSpillInfoRetriever/SBNDBNBRetriever/SBNDBNBRetriever_module.cc
Outdated
Show resolved
Hide resolved
sbncode/BeamSpillInfoRetriever/SBNDBNBRetriever/SBNDBNBRetriever_module.cc
Outdated
Show resolved
Hide resolved
sbncode/BeamSpillInfoRetriever/SBNDBNBZEROBIASRetriever/MWRData.cpp
Outdated
Show resolved
Hide resolved
sbncode/BeamSpillInfoRetriever/SBNDBNBZEROBIASRetriever/SBNDBNBZEROBIASRetriever_module.cc
Show resolved
Hide resolved
Add catch
Add catch zerobias
update zerobias fcl param
|
Hi @nathanielerowe, just to check - did the checks @jzennamo mentioned get done? I note in DocDBs 39679 and 39601 there were some minor issues - were those part of those checks? Thanks! |
|
@kjplows The only outstanding check is the gate normalized top-hat plot. This required a fix to the PTB which should be going in some time today. |
jzennamo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! Thank you so much for all your work on this!
justinjmueller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks!
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
Brilliant, huge thanks to everyone for all your hard work! CI tests happy so prepping this for release now. 💪 |
Splitting the PR for POT Accounting into two components. An additional PR will follow this which fixes a bug in the ICARUS POT accounting and reorganizes the directory a bit.
Requires updated PTB information from sbndaq_artdaq_core/v01_10_03 as well as sbndaq_artdaq/v01_10_03.
This PR introduces three producer modules, summarized in presentation at SBND Dec 2024 Collab Meeting.
Remaining issues were determined to be beam related. Behavior is stable with new BNBZeroBias stream.