Skip to content

Conversation

@nathanielerowe
Copy link
Contributor

Splitting the PR for POT Accounting into two components. An additional PR will follow this which fixes a bug in the ICARUS POT accounting and reorganizes the directory a bit.

Requires updated PTB information from sbndaq_artdaq_core/v01_10_03 as well as sbndaq_artdaq/v01_10_03.

This PR introduces three producer modules, summarized in presentation at SBND Dec 2024 Collab Meeting.

Remaining issues were determined to be beam related. Behavior is stable with new BNBZeroBias stream.

@nathanielerowe nathanielerowe added the enhancement New feature or request label Dec 13, 2024
Copy link
Contributor

@jzennamo jzennamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would would be good to verify that this is doing what we expect it to do with data. Both running the modules and seeing if we can co-normalize the samples but also what happens when we run modules on the "wrong" sample?

@ibsafa ibsafa requested a review from jzennamo January 14, 2025 15:04
@kjplows
Copy link
Contributor

kjplows commented Feb 10, 2025

Hi @nathanielerowe, just to check - did the checks @jzennamo mentioned get done? I note in DocDBs 39679 and 39601 there were some minor issues - were those part of those checks? Thanks!

@nathanielerowe
Copy link
Contributor Author

@kjplows The only outstanding check is the gate normalized top-hat plot. This required a fix to the PTB which should be going in some time today.

Copy link
Contributor

@jzennamo jzennamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Thank you so much for all your work on this!

Copy link

@justinjmueller justinjmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Mar 18, 2025
@kjplows
Copy link
Contributor

kjplows commented Mar 18, 2025

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Mar 18, 2025
@kjplows
Copy link
Contributor

kjplows commented Mar 18, 2025

Brilliant, huge thanks to everyone for all your hard work! CI tests happy so prepping this for release now. 💪

@kjplows kjplows merged commit c3cdd3a into develop Mar 18, 2025
4 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Mar 18, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Mar 18, 2025
@bear-is-asleep bear-is-asleep moved this from Todo to In tagged release in SBND March 2025 production Mar 18, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Mar 27, 2025
@nathanielerowe nathanielerowe deleted the feature/sbnd_bnb_only branch November 5, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

7 participants