Update xmlseclibs requirement to ^4.0 due GHSA-m5mw-mr39-66vp - #655
Open
scybulski wants to merge 2 commits into
Open
Update xmlseclibs requirement to ^4.0 due GHSA-m5mw-mr39-66vp#655scybulski wants to merge 2 commits into
scybulski wants to merge 2 commits into
Conversation
Addresses AIKIDO-2026-134354; require PHP >=8.0. Legacy IdPs can enable security.allowRSA15KeyTransport for RSA-1.5 encrypted assertions/NameIDs. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Thanks @scybulski for the collaboration, I will review carefully and merge asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
#654
Upgrades
robrichards/xmlseclibsfrom^3.1.5to^4.0to address a critical signature-forgery vulnerability. Adds a newsecurity.allowRSA15KeyTransportsetting (defaultfalse) so deployments with legacy IdPs that still use RSA-1.5 key transport can opt in during migration, while secure defaults remain unchanged.Security
This addresses:
xmlseclibs< 4.0.0; fixed in4.0.0xmlseclibs4 also denies RSA-1.5 key transport by default (Bleichenbacher risk). This PR maps that behavior to an explicit toolkit setting rather than silently breaking encrypted assertions/NameIDs for legacy peers.Changes
robrichards/xmlseclibsto^4.0>=8.0(required by xmlseclibs 4)security.allowRSA15KeyTransport(defaultfalse); documented inadvanced_settings_example.phpUtils::decryptElement()/Utils::createDecryptionContext()Response(encrypted assertions and encrypted NameIDs)LogoutRequest::getNameIdData(),getNameId(), andisValid()CHANGELOGunder[UNRELEASED]Breaking changes
>=8.0required (was>=7.3)security.allowRSA15KeyTransport => trueis set for a given IdP/integrationMigration notes
For most deployments, no config change is needed.
If decryption fails with "RSA-1.5 key transport is disabled":
This mirrors xmlseclibs 4 guidance: use algorithm allowlists / secure defaults, and enable legacy RSA-1.5 only temporarily while migrating peers.
Test plan
./vendor/bin/phpunit— 300 tests, 1330 assertionsallowRSA15KeyTransport => truefalseReferences
v4.3.2(xmlseclibs3.1.5),v4.3.1(xmlseclibs3.1.4)