Corrects wrong "current url" when behind a reverse proxy#642
Open
lezab wants to merge 1 commit intoSAML-Toolkits:4.x-devfrom
Open
Corrects wrong "current url" when behind a reverse proxy#642lezab wants to merge 1 commit intoSAML-Toolkits:4.x-devfrom
lezab wants to merge 1 commit intoSAML-Toolkits:4.x-devfrom
Conversation
… url path than the one on the server. Integrates proxy usage in Settings (settings_example.php updated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I some case, when behind a reverse proxy with a shorter url path than the one on the server, the current url could be wrong.
This proposition corrects that, by adding a localUrlPath parameter which allows to compute current url correctly.
The patch integrates also the proxy usage in Settings (settings_example.php updated)