Skip to content

Remove bincode dev-dependency #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Dec 18, 2025
Merged

Remove bincode dev-dependency #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crypto_box/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ salsa20 = { version = "0.11.0-rc.1", optional = true }
serdect = { version = "0.4", optional = true, default-features = false }

[dev-dependencies]
bincode = "1"
hex-literal = "0.4"
rand = "0.9"
rmp-serde = "1"
Expand Down
48 changes: 0 additions & 48 deletions crypto_box/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,54 +336,6 @@ fn get_seal_nonce(ephemeral_pk: &PublicKey, recipient_pk: &PublicKey) -> Nonce {
mod tests {
use super::*;

#[cfg(feature = "serde")]
#[test]
fn test_public_key_serialization() {
use aead::rand_core::RngCore;

// Random PK bytes
let mut public_key_bytes = [0; 32];
let mut rng = rand::rng();
rng.fill_bytes(&mut public_key_bytes);

// Create public key
let public_key = PublicKey::from(public_key_bytes);

// Round-trip serialize with bincode
let serialized = bincode::serialize(&public_key).unwrap();
let deserialized: PublicKey = bincode::deserialize(&serialized).unwrap();
assert_eq!(deserialized, public_key,);

// Round-trip serialize with rmp (msgpack)
let serialized = rmp_serde::to_vec_named(&public_key).unwrap();
let deserialized: PublicKey = rmp_serde::from_slice(&serialized).unwrap();
assert_eq!(deserialized, public_key,);
}

#[cfg(feature = "serde")]
#[test]
fn test_secret_key_serialization() {
use aead::rand_core::RngCore;

// Random SK bytes
let mut secret_key_bytes = [0; 32];
let mut rng = rand::rng();
rng.fill_bytes(&mut secret_key_bytes);

// Create secret key
let secret_key = SecretKey::from(secret_key_bytes);

// Round-trip serialize with bincode
let serialized = bincode::serialize(&secret_key).unwrap();
let deserialized: SecretKey = bincode::deserialize(&serialized).unwrap();
assert_eq!(deserialized.to_bytes(), secret_key.to_bytes());

// Round-trip serialize with rmp (msgpack)
let serialized = rmp_serde::to_vec_named(&secret_key).unwrap();
let deserialized: SecretKey = rmp_serde::from_slice(&serialized).unwrap();
assert_eq!(deserialized.to_bytes(), secret_key.to_bytes());
}

#[test]
fn test_public_key_from_slice() {
let array = [0; 40];
Expand Down
Loading