refactor(nvvm): Remove cust_raw as a codegen dependency.
#193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codegen only needs `nvvm`, which itself take cust_raw as a dependency. It currently depends on `cust_raw` so that it can import libdevice bytecode from nvvm_sys. With this change, `nvvm` now exports libdevice bytecode from `cust_raw::nvvm_sys`, and removes `cust_raw` as a codegen dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen only needs
nvvm, which itself takecust_rawas a dependency. It currently depends oncust_rawso that it can import libdevice bytecode fromcust_raw::nvvm_sys. With this change,nvvmnow exports libdevice bytecode fromcust_raw::nvvm_sys, and removescust_rawas a codegen dependency.