[WIP] Assign NodeIds outside of constructors#4323
Draft
powerboat9 wants to merge 2 commits intoRust-GCC:masterfrom
Draft
[WIP] Assign NodeIds outside of constructors#4323powerboat9 wants to merge 2 commits intoRust-GCC:masterfrom
NodeIds outside of constructors#4323powerboat9 wants to merge 2 commits intoRust-GCC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch moves node id storage/handling into a subclass,
HasNodeId, and requires that nodes be explicitly assigned a node id before they can have their node id fetched.Pros:
Cons:
NodeIdVisitoris created to handle thisHasNodeIdneeds to be explicitly initialized in copy constructors for derived classes. Otherwise the result of a copy has no assigned node id, instead of copying the original node's node idDespite the cons, this is probably the best method available for solving the how-do-we-copy-nodes-with-or-without-node-id problem, as the alternative seems to be playing wack-a-mole with copy-vs-reconstruct in the derive handling code.