fix: remove HTML entity unescaping from all tool implementations#10234
Closed
roomote[bot] wants to merge 1 commit intomainfrom
Closed
fix: remove HTML entity unescaping from all tool implementations#10234roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Review complete. No issues found. The PR correctly removes the Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #9563
Roo Code Task Context (Optional)
N/A
Description
This PR attempts to address Issue #9563 by removing the unescapeHtmlEntities function from all tool implementations that were inadvertently converting HTML entities to their literal character equivalents.
The problem was that HTML entities like ', <, > were being decoded to literal characters before tool operations were executed. This broke operations on JSX/TSX files and other scenarios where users intentionally wanted to use HTML entities.
Changes made:
Test Procedure
Pre-Submission Checklist
Feedback and guidance are welcome!