feat: add jump-to-file navigation for file edit operations#10145
Closed
roomote[bot] wants to merge 1 commit intomainfrom
Closed
feat: add jump-to-file navigation for file edit operations#10145roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
When auto-approve is enabled, users could not easily navigate to edited files since the diff view was skipped. This change adds the onJumpToFile prop to CodeAccordian for editedExistingFile, appliedDiff, insertContent, and searchAndReplace operations, allowing users to click the external link icon to open the edited file. Fixes #10144
Closed
Contributor
Author
Reviewed the changes. The PR correctly adds the
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #10144
Roo Code Task Context (Optional)
This PR was created by Roo Code to address a feature request from the issue.
Description
This PR adds the ability to navigate to edited files directly from the chat panel, even when auto-approve is enabled.
The Problem:
When users enable auto-approve, the diff view is skipped, making it difficult to navigate to the edited file location. The user reported this in issue #10144.
The Solution:
The
CodeAccordiancomponent already supports anonJumpToFileprop that displays an external link icon to open files. However, this prop was only being passed for thenewFileCreatedtool case.This PR adds the
onJumpToFileprop to the following file edit operations:editedExistingFile/appliedDiffinsertContentsearchAndReplaceNow users can click the external link icon in the file header to open the edited file, regardless of whether auto-approve is enabled.
Test Procedure
Automated tests:
npx vitest run src/components/chat/__tests__/ChatRow.diff-actions.spec.tsx- all tests passPre-Submission Checklist
Screenshots / Videos
N/A - The UI change is minimal (external link icon already exists, now visible for more tool types).
Documentation Updates
Additional Notes
This is an attempt to address the feature request from issue #10144. Feedback and guidance are welcome.
Get in Touch
@roomote