Merged
Conversation
Adding a new, optional, API to accompany the Grimwild character sheet, enabling enhanced roll outputs.
Alicekb
approved these changes
Oct 7, 2025
Contributor
|
Hey @Dedalus36, it looks like there is an issue in your |
Contributor
Author
|
Thanks for the heads up, @Alicekb! Was just missing a comma, should be good to verify now. |
NorWhal
requested changes
Oct 9, 2025
| "useroptions": [], | ||
| "dependencies": [], | ||
| "modifies": [], | ||
| "conflicts": [], |
Contributor
There was a problem hiding this comment.
Trailing commas aren't allowed in JSON
Suggested change
| "conflicts": [], | |
| "conflicts": [] |
Contributor
|
I think the above is the issue that needed fixing, @Dedalus36 |
Contributor
Author
|
I've reviewed the script.json again and think the original issue might have been including the modifies field as an array rather than an object. That change, and the incorrect edit I made to the comma that NorWhal flagged, have now been corrected. Let me know if additional edits are needed. Thanks for your time! |
Alicekb
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new optional API to accompany the Grimwild character sheet, enabling enhanced roll outputs.