bad boy createchannel punished and identity changed / issue #468 pull request #474
Open
Nishikiyama wants to merge 4 commits intoRoinujNosde:masterfrom
Open
bad boy createchannel punished and identity changed / issue #468 pull request #474Nishikiyama wants to merge 4 commits intoRoinujNosde:masterfrom
Nishikiyama wants to merge 4 commits intoRoinujNosde:masterfrom
Conversation
changed a lot of the code inside create channel, created new func called channelisBeingCreated
Tomut0
reviewed
Feb 24, 2026
Comment on lines
+380
to
+383
| // double validation!!! | ||
| if (channelExists(clanTag)) { | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
Not enough, would be great to check on sun cycles to be sure
Contributor
Author
There was a problem hiding this comment.
Hmm. How would one implement that?
im sure it will work better now
…UB AND NOT THE GAME
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed a lot of the code inside create channel, created new func called channelisBeingCreated
its omega minimalistic as a change because im a minimalistic human but i will fix it the long way around if i have to