-
-
Notifications
You must be signed in to change notification settings - Fork 262
ENH: Add python loggers #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
YuriCastroDev
wants to merge
17
commits into
RocketPy-Team:develop
Choose a base branch
from
YuriCastroDev:enh/issue-450-adopt-python-loggers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d519cf1
ENH: adopt built-in Python logging instead of print() calls
YuriCastroDev f68d0ce
ENH: adopt built-in Python logging instead of print() calls
YuriCastroDev f5cf90d
ENH: adopt built-in Python logging instead of print() calls
YuriCastroDev 64d32e5
ENH: adopt built-in Python logging instead of print() calls
YuriCastroDev 2f007aa
ENH: adopt built-in Python logging instead of print() calls
YuriCastroDev 22149db
ENH: adopt built-in Python logging for internal runtime events
YuriCastroDev 0aa8004
ENH: adopt built-in Python logging for internal runtime events
YuriCastroDev 1ad7f4c
STY: fix formatting with ruff and black
YuriCastroDev de28b57
STY: fix formatting with ruff and black
YuriCastroDev 586f08a
Update rocketpy/environment/environment.py
YuriCastroDev cc2cf57
Update rocketpy/environment/environment.py
YuriCastroDev a6b7a5f
Update rocketpy/environment/tools.py
YuriCastroDev 120ccd8
Update rocketpy/mathutils/function.py
YuriCastroDev 1e2a257
Update rocketpy/mathutils/vector_matrix.py
YuriCastroDev a29f05f
MNT: address PR review comments on nose_cone and tools
YuriCastroDev 21b4f7d
MNT: fix docstrings and scope debug log to verbose flag
YuriCastroDev 2fb3fe3
MNT: restore SimMonitor print behavior for multiprocessing compatibility
YuriCastroDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you agree that these message will stop making sense here?
The prints existed to separated each plot from the next one.
If we turn these into info logs, the user may not seeing them (unless they implement a handler).
On the other hand, if a user consumes the log without seeing the plot, it doesn't really make sense at all (i.e. reading "airfoil lift curve" doesn't make as much sense as reading "plotting airfoil lift curve")
In other words, we need to rethink what we really want to display in each message within the plots module.