Skip to content

fix: Button not working with Physical Keyboard #7060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OtavioStasiak wants to merge 7 commits into
base: develop
Choose a base branch
from
+1,666 −1,195
Open

fix: Button not working with Physical Keyboard #7060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2c1b06
fix: Pressable issues
OtavioStasiak Mar 19, 2026
993c356
fix: tests
OtavioStasiak Mar 19, 2026
40c4203
Merge branch 'develop' into fix.keyboard-button-not-working
OtavioStasiak Mar 24, 2026
ea95f8c
use rectButton
OtavioStasiak Mar 24, 2026
7f9bb63
update snapshot
OtavioStasiak Mar 24, 2026
2f5acdf
Merge branch 'develop' into fix.keyboard-button-not-working
OtavioStasiak Mar 24, 2026
fba20f8
fix: unit tests
OtavioStasiak Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/containers/Button/Button.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ describe('ButtonTests', () => {
test('disabled button is in disabled state', async () => {
const { findByTestId } = render(<TestButton disabled={true} />);
const button = await findByTestId(testProps.testID);
// In the test environment, RNGH Pressable may still invoke onPress when disabled,
// so we assert the button is in a disabled state (enabled={false}).
// RectButton uses enabled={false}; RNGestureHandlerButton in Jest still invokes onPress from fireEvent.press
expect(button.props.enabled).toBe(false);
});

Expand Down
Loading
Loading