Open
Conversation
Daniel-E-B
requested changes
Feb 2, 2019
Member
Daniel-E-B
left a comment
Daniel-E-B
left a comment
There was a problem hiding this comment.
overall looks good. we should do a full test of all of this on the robot to tune all of the constants (some of which should maybe be stored somewhere in yearly code?). Also change the logkitten levels back
billwpierce
requested changes
Feb 4, 2019
Member
billwpierce
left a comment
billwpierce
left a comment
There was a problem hiding this comment.
Look at my comments. It looks fine, and I might just be misunderstanding the changes, but I'd like clarification on some things.
billwpierce
requested changes
Feb 14, 2019
Member
billwpierce
left a comment
billwpierce
left a comment
There was a problem hiding this comment.
left a couple of small changes, but looks mostly good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made automated system check framework for the robot