made changes to replace deprecated methods in standard#225
Open
NikhilSuresh24 wants to merge 5 commits intomainfrom
Open
made changes to replace deprecated methods in standard#225NikhilSuresh24 wants to merge 5 commits intomainfrom
NikhilSuresh24 wants to merge 5 commits intomainfrom
Conversation
Daniel-E-B
approved these changes
Feb 1, 2019
custom/sensors/NavX.java
Outdated
| package org.usfirst.frc4904.standard.custom.sensors; | ||
|
|
||
|
|
||
| import org.usfirst.frc4904.standard.LogKitten; |
Member
There was a problem hiding this comment.
rather than getting rid of this, maybe consider logging navx errors?
Member
Author
There was a problem hiding this comment.
this should probably be a diff branch
oshlern
approved these changes
Feb 10, 2019
Contributor
oshlern
left a comment
oshlern
left a comment
There was a problem hiding this comment.
Ready for testing! Looks good as long as it actually works.
b-cho
approved these changes
Dec 7, 2019
Contributor
b-cho
left a comment
b-cho
left a comment
There was a problem hiding this comment.
Ok—not tested but I don't know how to test it because there are no visible differences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed several files to remove calls of deprecated methods