Skip to content

SEVERE BUG IN LOGKITTEN -- INCORRECT LOGGING #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leijurv wants to merge 5 commits into
base: main
Choose a base branch
from
Open

SEVERE BUG IN LOGKITTEN -- INCORRECT LOGGING #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ea77fe
Update LogKitten.java
leijurv Jan 6, 2018
af5cb3d
Update LogKitten.java
leijurv Jan 7, 2018
eb99505
Update KittenCommand.java
leijurv Jan 7, 2018
19b235c
Merge branch 'master' into leijurv-patch-3
oldgalileo Jan 7, 2018
90005b1
Merge branch 'master' into leijurv-patch-3
oldgalileo Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion LogKitten.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,12 @@ public static void setPrintMute(boolean mute) {
private static void reportErrorToDriverStation(String details, String errorMessage, KittenLevel logLevel) {
HAL.sendError(true, logLevel.getSeverity(), false, errorMessage, details, "", false);
}

public static void indirectedLogMessage(Object message, KittenLevel level, boolean override) {
logMessage(message, level, override);
}

public static synchronized void logMessage(Object message, KittenLevel level, boolean override) {
private static synchronized void logMessage(Object message, KittenLevel level, boolean override) {
message = message.toString(); // Not strictly needed, but good practice
if (LogKitten.logLevel.compareTo(level) >= 0) {
String content = LogKitten.timestamp() + " " + level.getName() + ": " + LogKitten.getLoggerMethodCallerMethodName()
Expand Down
2 changes: 1 addition & 1 deletion commands/KittenCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public KittenCommand(String message, LogKitten.KittenLevel level) {

@Override
protected void initialize() {
LogKitten.logMessage(message, level, false);
LogKitten.indirectedLogMessage(message, level, false);
}

@Override
Expand Down