Open
Conversation
Contributor
|
What is the error when using the older sysroot version? |
Contributor
Author
|
It will result in the following error: The relevant file for the first error is https://github.com/torvalds/linux/blob/master/include/linux/can/bittiming.h |
Member
|
@wolfv suggested the right solution, we should add an option to set a custom variant.yaml in the recipe that require a |
Contributor
|
Needs RoboStack/vinca#114 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds building for the canopen packages, including its dependency on ros-jazzy-lely-core-libraries.
Since lely-core-libraries relies on newer linux CAN header files, the c_stdlib_version needs to be higher for this package. I tried to add
to the dependencies.yaml, however this does not work because then the depency will be listed two times in the generated reciepe.yaml. I am not sure if this is really a change that you want to merge. Feel free to reject this PR. In that case people can still find it here if they want to build lely-core-libraries on their own.
The patch file is also ugly. I spend a lot of time debugging the build of lely-core-libraries and this was the best I could come up with. It first installs everthing to an intermediate folder and then installs it from there to the final destination.